[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] ioreq_broadcast(): accept partial broadcast success


  • To: Per Bilse <per.bilse@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 7 Dec 2022 10:05:49 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8NnTJrIX9yVfzKsX7gi8eQ/oYaq8/R9FEhj+m/cfizA=; b=hj/gh34BkzLEorhwusvIOsidXWYw94y5JRXFwNewrXNKcpHQFrvVSKzZI8FU5hk8LHy/+jyOI2aljyWFxxLj2ZpO586BgwqiGNJTRrvH3/ZK58xf5D/zSRx4gS2aVRiodzZ2vRKMx9VC0jZGWzBUy/ThGBEt6gAiyhmGM3E/+ixKDs33+SZSVHNNGLZIdD9xOQapShJVZTBgiN5Mzj6ukAnIy/XobO56wUFiFyfb6UTxThnAAbABUjGLRqsdOqCFlbr2vgmN/TXryjo6D4Edt2FQO9PPiFvYmdGFg3yAx/9YJhfI6R4RUInUCwVQgilC6Vl8DqkoMBunIvyoKrS1Qw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mmZZTerTcveT47wvS1VAvEsXEsBZGekV0BXAY+ATm2623ek9F09Nt9ExOpTS/0UJy3JfL9T8LZYVeh5A/owcg51dHIR7wFwYCSeCZd5t2LSLn/vNtPLxnVje60WK8o5SZNvqxAzUxodGkN46naNd/cQcre2+DtjIkvuOXEI+GlDgd8N+LihMjW1uvEyENBUs4kRiVFP6XoBQ+j1tu84FzKPBZQD9blHD5N8mQBvfuM6rmVzxmXP1oMlGE/zlGOLpO2vr+2exra4ZaRII8/w4Ul1g5nv3Z1iJ3s9dZCZN927FaqWaiVNeV9AbhC4sqdhvGN8vvgsLS/e0P+R10ZrVhQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Paul Durrant <paul@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 07 Dec 2022 09:06:29 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 06.12.2022 18:52, Per Bilse wrote:
> --- a/xen/common/ioreq.c
> +++ b/xen/common/ioreq.c
> @@ -1317,7 +1317,8 @@ unsigned int ioreq_broadcast(ioreq_t *p, bool buffered)
>  
>      FOR_EACH_IOREQ_SERVER(d, id, s)
>      {
> -        if ( !s->enabled )
> +        if ( !s->enabled || (buffered &&
> +                    s->bufioreq_handling == HVM_IOREQSRV_BUFIOREQ_OFF) )

Nit: Bad indentation. Since inserting the missing blanks would make
the line too long, the expression wants re-wrapping. Can certainly
be done while committing.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.