Re: [PATCH 19/19] Fix misleading indentation gcc warning

[Julien Grall <julien@xxxxxxx>]

Hi,

On 07/10/2022 11:32, Mykyta Poturai wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>
> percpu.c: In function 'cpu_percpu_callback':
> percpu.c:61:7: error: this 'if' clause does not guard... 
> [-Werror=misleading-indentation]
>         if ( system_state != SYS_STATE_resume )
>         ^~
> percpu.c:63:9: note: ...this statement, but the latter is misleadingly indented 
> as if it were guarded by the 'if'
>           break;
>           ^~~~~
> percpu.c:67:7: error: this 'if' clause does not guard... 
> [-Werror=misleading-indentation]
>         if ( system_state != SYS_STATE_suspend )
>         ^~
> percpu.c:69:9: note: ...this statement, but the latter is misleadingly indented 
> as if it were guarded by the 'if'
>           break;
>           ^~~~~
>
> Fixes: c3109b76d967 ("xen: don't free percpu areas during suspend")
This commit hash doesn't seem to exist upstream. But it sounds like you 
are fixing a bug that was introduced by this series.
In general, patch within a series should be able to compile without any 
follow-up requirement. Similarly, we should not bug fix a patch within 
the same series.
Instead, this should be folded in the patch that introduced the problem.

Cheers,

--
Julien Grall