Re: [PATCH 00/19] xen/arm64: Suspend to RAM support for Xen

[Julien Grall <julien@xxxxxxx>]

On 06/12/2022 20:32, Julien Grall wrote:
> Hi,
>
> On 07/10/2022 14:08, Mykyta Poturai wrote:
> > This is a series from Mirela Simonovic. Ported to 4.16 and with
> > added changes suggested here
> > https://lore.kernel.org/all/CAKPH-NjmaZENb8gT=+FobrAycRF01_--6GuRA2ck9Di5wiudhA@xxxxxxxxxxxxxx
> >
> > This series contains support for suspend to RAM (in the following text 
> > just
> > 'suspend') for Xen on arm64. The implementation is aligned with the 
> > design
> > specification that has been proposed on xen-devel list:
> > https://lists.xenproject.org/archives/html/xen-devel/2017-12/msg01574.html
> >
> > At a high-level the series contains:
> > 1) Support for suspending guests via virtual PSCI SYSTEM_SUSPEND call
> > 2) Support for resuming a guest on an interrupt targeted to that guest
> > 3) Support for suspending Xen after dom0 finalizes the suspend
> > 4) Support for resuming Xen on an interrupt that is targeted to a guest
>  From the previous discussion, there were a few dubious code in 
> cpu_disable() (e.g. mdelay()). So did you go through the code to confirm 
> it is fully Arm compliant?
Another missing pieces is that we don't free anything related to the CPU 
that is been powered down. But AFAICT, we will end up to allocate the 
memory again for things like page tables, per-cpu...
Cheers,

--
Julien Grall