[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] x86/pv-shim: don't even allow enabling GRANT_TABLE
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Tue, 6 Dec 2022 20:26:11 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GfBuhpMhHEEvlFTIwfh6wXQGgFcjZmbQ8Jk261YuVYk=; b=Ya2fhWwztz9MwJ3LtLdyDgCG1Hsrpc5Ci6hHaiwplle5/zYbMTLDVgle0hGsGgffMZqMCS8IUyUpQbFYJfIA6kx+IhthwoyskqPfVMuKmAGP2ZGTy4ZoVQVrmCI1sDSJnLb20ZvF4AoMNSGzcPkBlrIMhceVlQgGwyvcMd6ekTv3cx/ZOR1Izwpc2zWRUm278yz1mdbOdCYjueAY6f4WIXvjYVNxWU8Z4zv5F0/hJr2gnYqNmX9cpDk0q/9KRWjIKPNE61lZ9fgov4IIGIhuXLZmJx6xOOxg4Ani5NI95Pb6Bpib8y8mYg8dzbDnnVX2Q6EVI7D1g34tklKYbRImYQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=axW2UUNXRNzWCXSh49gExk/LU9Du7siNxS+DDZjLojXtxhtWKUbbgyCik30sSABZNTNsZQcBZywgGTz0wkIdLnpO27G2JZbON0eex6JbJZxNSheXmcXzpTJjpPSjj20ayL0PSI7T4d3XT1rZAXk2DFu8V4sHb6jlGgxCzrDGYMFUY0wvkGkLLgXr5F0TW9hMhXF+U6fx7dKpPeYtXkbkCmUaFwukklWQDlcftOTjGlttTqg4kAkbSMHuVk46b6mudvCvii7CltmLsq7hgxOtu6DMGAjudiQUg8vyvwJqv4csQU9c43FcKOI9k9EfvRxBTVLccwhJXgnCnTfExTD3JQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 06 Dec 2022 20:26:40 +0000
- Ironport-data: A9a23:PRyUnKAFhXkjrxVW/+Piw5YqxClBgxIJ4kV8jS/XYbTApGkrg2YDm 2VNWT2DPK2Da2X8f98jboS/pEwP6JOAz4UxQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WlA4ARlDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwvfZJIUgRx aYjASEjVyq6pKHq7Oz4Rbw57igjBJGD0II3nFhFlGucIdN4BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI9OxuvDa7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr+ewXmlBdNKfFG+3q5v33+2+GATMRgHZ3zjv9P+h0SsW+sKf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRHsqCRSH+b3qeZq3W1Iyd9BXQZeSYOQA8B4t/iiII+lBTCSpBkCqHdpsLxMSH9x XaNtidWulkIpcsC1qH+8VWZhTup/8LNVlRsuVuRWX+55ARkYoLjf5av9VXQ8fdHKsCeU0WFu 38H3cOZ6YjiEK2wqcBEe81VdJnB2hpPGGe0bYJHd3X5ywmQxg==
- Ironport-hdrordr: A9a23:lrgAf6BCwO27/EvlHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZCX9NIrDy49JalkChlMsM+HKSta5hTvUA
- Thread-topic: [PATCH 2/3] x86/pv-shim: don't even allow enabling GRANT_TABLE
On 06/12/2022 14:30, Jan Beulich wrote:
> Grant table code is unused in shim mode, so there's no point in
> building it in the first place for shim-exclusive mode.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
nack.
This is bogus, as is every other "depends on !PV_SHIM_EXCLUSIVE".
The only reason I haven't reverting the others so `make allyesconfig`
doesn't disable CONFIG_HVM, is because I haven't had time. This change
further breaks allyesconfig by disabling GRANT_TABLE too.
PV_SHIM_EXCLUSIVE is a simple option for a bit of dead code
elimination. It is not valid to be used like this.
~Andrew
|
