Re: [PATCH V6 2/3] xl: Add support to parse generic virtio device

[Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>]

On 05.12.22 08:20, Viresh Kumar wrote:

Hello Viresh

> On 02-12-22, 19:16, Oleksandr Tyshchenko wrote:
> > Interesting, I see you allow user to configure virtio-mmio params (irq and
> > base), as far as I remember for virtio-disk these are internal only
> > (allocated by tools/libs/light/libxl_arm.c).
> It is a mistake. Will drop it.

ok, good. Please don't forget to add a note to idl file that virtio-mmio 
params are internal only.

libxl_device_virtio = Struct("device_virtio", [
    ...

    # Note that virtio-mmio parameters (irq and base) are for internal
    # use by libxl and can't be modified.
    ("irq", uint32),
    ("base", uint64)
    ])


>