Xen project Mailing List

Re: [PATCH] xen: Remove trigraphs from comments

From: Luca Fancellu <Luca.Fancellu@xxxxxxx>

Date: Tue, 6 Dec 2022 11:09:41 +0000

Accept-language: en-GB, en-US

Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8NkYmRwVXu3wBQfoRDjrQrBGKtF/ev1ry2PuycJ+fuU=; b=DDFJAhhJ0u3Bo35R1h3TISCLf8Pq49I8aUYdOOZsANsbbeGsW4PHb4qvvlnbgTLLTzKmpRiFi/xiLtrIKScWSOgox/kCy3WS5wt0OQPP34JFcW4p8FE5W9TG8SW5qmEXDJW+nKQfqr9pzanmwzaVCZxOtJCTItdm0OWOZj5tUV+TVGzpTZfZH711gqLtCyC+EUw79AZpS8UyEgytw2UESBb3X3OhmbRACvsnXyhXJ2RFoxzhTuAgU9rQDA38J2R0AwiRLqxK9h1BBvcc6Z6Nvmcayl8u35YrL0znV1sX0bmiqFT8FvRZslaU8Wj1JIl6U/AmiYTf3d7qExwhfECokw==

Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dHUCKD4VP26Y4pc05MpRDzM8mirYSDu59AZai9VXuC509RXP3PkBjgWxaxreKzw+NPoxRrgglU11rFp0b5iYbvtiDCJ0e1cdQW+F2hdznB7UN/1j7/4I/+7OUkeLDT6P8EZp6BWeBk70kdHrz6XlZSlcsCBZspRCzEE0qcZZuyZdYGX5GM1HK+ktsW+fHRXrxD/FW0yOtnKvRl5gVDBQJ6RBv/az561tm1SjrjXl/LNMF/d5DqkUSJcw43h70GWRQiH5Y3XI2sX8kl1u3Qh3yguw5ht2MtUVVZuZS8AeFpoa8SE0AF/QjhStj5+ASvVenJVTwB0HcMMp83sgRrY8HA==

Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;

Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>

Delivery-date: Tue, 06 Dec 2022 11:09:59 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Nodisclaimer: true

Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;

Thread-index: AQHZCWINLKlK6tI5CE6qpK6tmjbd665gs6gA

Thread-topic: [PATCH] xen: Remove trigraphs from comments

> On 6 Dec 2022, at 10:59, Michal Orzel <michal.orzel@xxxxxxx> wrote: > > MISRA C rule 4.2 states that trigraphs (sequences of two question marks > followed by a specified third character [=/'()!<>-]) should not be used. > This applies to both code and comments. Thankfully, we do not use them > in the code, but still there are some comments where they are > accidentally used. Fix it. > > Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx> > --- > xen/arch/x86/x86_emulate/x86_emulate.h | 2 +- > xen/include/public/arch-x86_64.h | 2 +- > xen/include/xen/pci_regs.h | 12 ++++++------ > 3 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/xen/arch/x86/x86_emulate/x86_emulate.h > b/xen/arch/x86/x86_emulate/x86_emulate.h > index 4732855c40ed..bb7af967ffee 100644 > --- a/xen/arch/x86/x86_emulate/x86_emulate.h > +++ b/xen/arch/x86/x86_emulate/x86_emulate.h > @@ -228,7 +228,7 @@ struct x86_emulate_ops > * All functions: > * @ctxt: [IN ] Emulation context info as passed to the emulator. > * All memory-access functions: > - * @seg: [IN ] Segment being dereferenced (specified as x86_seg_??). > + * @seg: [IN ] Segment being dereferenced (specified as x86_seg_?). > * @offset:[IN ] Offset within segment. > * @p_data:[IN ] Pointer to i/o data buffer (length is @bytes) > * Read functions: > diff --git a/xen/include/public/arch-x86_64.h > b/xen/include/public/arch-x86_64.h > index 5db52de69584..1c3567a20217 100644 > --- a/xen/include/public/arch-x86_64.h > +++ b/xen/include/public/arch-x86_64.h > @@ -22,5 +22,5 @@ > * A similar callback occurs if the segment selectors are invalid. > * failsafe_address is used as the value of eip. > * > - * On x86_64, event_selector and failsafe_selector are ignored (???). > + * On x86_64, event_selector and failsafe_selector are ignored (?). > */ > diff --git a/xen/include/xen/pci_regs.h b/xen/include/xen/pci_regs.h > index ee8e82be36b4..a90aff1712ba 100644 > --- a/xen/include/xen/pci_regs.h > +++ b/xen/include/xen/pci_regs.h > @@ -246,13 +246,13 @@ > #define PCI_PM_CTRL_STATE_MASK 0x0003 /* Current power state (D0 to D3) */ > #define PCI_PM_CTRL_NO_SOFT_RESET 0x0008 /* No reset for D3hot->D0 */ > #define PCI_PM_CTRL_PME_ENABLE 0x0100 /* PME pin enable */ > -#define PCI_PM_CTRL_DATA_SEL_MASK 0x1e00 /* Data select (??) */ > -#define PCI_PM_CTRL_DATA_SCALE_MASK 0x6000 /* Data scale (??) */ > +#define PCI_PM_CTRL_DATA_SEL_MASK 0x1e00 /* Data select (?) */ > +#define PCI_PM_CTRL_DATA_SCALE_MASK 0x6000 /* Data scale (?) */ > #define PCI_PM_CTRL_PME_STATUS 0x8000 /* PME pin status */ > -#define PCI_PM_PPB_EXTENSIONS 6 /* PPB support extensions (??) */ > -#define PCI_PM_PPB_B2_B3 0x40 /* Stop clock when in D3hot (??) */ > -#define PCI_PM_BPCC_ENABLE 0x80 /* Bus power/clock control enable (??) */ > -#define PCI_PM_DATA_REGISTER 7 /* (??) */ > +#define PCI_PM_PPB_EXTENSIONS 6 /* PPB support extensions (?) */ > +#define PCI_PM_PPB_B2_B3 0x40 /* Stop clock when in D3hot (?) */ > +#define PCI_PM_BPCC_ENABLE 0x80 /* Bus power/clock control enable (?) */ > +#define PCI_PM_DATA_REGISTER 7 /* (?) */ > #define PCI_PM_SIZEOF 8 > > /* AGP registers */ > -- > 2.25.1 > >

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.