Re: [PATCH] tools: Fix removal of COPYING and .gitignore

[Juergen Gross <jgross@xxxxxxxx>]

On 06.12.22 08:25, Viresh Kumar wrote:
> The Makefile continues to remove the entire tools/include/xen/ directory
> on "make clean", which isn't the right thing to do anymore since this
> file contains files like COPYING and .gitignore now.
I don't see a .gitignore file in tools/include/xen, and the COYPING file
is created by tools/include/Makefile when creating tools/include/xen.

> Since there are only two files at the moment, use "xen/[a-z]*" regex to
> remove everything else.
>
> Fixes: 4ea75e9a9058 ("Rework COPYING installed in /usr/include/xen/, due to several 
> licences")
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
NAK.

> ---
> I got into trouble as my build script does a "make clean" before building
> everything again and so build fails without the COPYING file.
This is working just fine for me.

> Based of:
>
> https://xenbits.xen.org/gitweb/?p=people/julieng/xen-unstable.git;a=shortlog;h=refs/heads/for-next/4.18
Maybe in the tree you are using commit 25b55688e1f20ebb is missing?


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature