[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/5] multiboot2: parse console= option when setting GOP mode


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 5 Dec 2022 17:01:24 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6Wx0EcCbIXoLY8ukf46jNQxdvux6JH0MbT37A0aXCnI=; b=eyItqa0rn2Imo91KhgZxC/JEli3X7TCa3gBUg2TnwnyiyR0Hq+op72dIgmCf2kyiekztAr9eVi+aYDYr1aPIZyCetjEl41dIkTfmIM/KtJEbHglrpTcCirruuTQnouBN1fyEQz2e9psQioqPlo9yT0c2ibPcvqOxv2USkCS3mG7fnH1u+1KKc8K4oAsH5hkFTmV26qvdw2LXoyFA8EEbORj5hoe+et2SS8l0NASJfcjA/W5Qjgb1hiU5jsXh8Q/vHAHTw8MS7GXRWuiIzIfa+98FqXX57NT4CmWfeIlbKF+Zi4EImTGaYFr788OfxQC7ipWIIJstS0UHzNLR1zvDfw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a33q+s502qMVPbgmBBw+0ne+8aIKzVbiGELxs0a7t3a3ok7KQfnvQTsxsDHL2VX/Ya6Y14NYPabBtywKNrlMJMIeoHZXwyjGnorjNUvNNXFH/DG8nfvfF/BVNYw3DbdQ7ngFye0Mt5ZdrtBlnuVC4/ONDYHyAH5aqR/v3LlZ74asgShelsZ+IWidyUqeWxmsIYaIfZ2PYAgTzOj/WYP/ewv40EjlatNLMb5mF/sPRomJdUALcoWz9wrUDY6V48Ced2LAp83hVoUFz55QyMLr2z/lkvYgCi4ijME7tUscsZPalpLzj7FL1FDi+4OmQAt87iNYB2CmF++lqb/3+fGQIA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: marmarek@xxxxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Daniel Kiper <daniel.kiper@xxxxxxxxxx>
  • Delivery-date: Mon, 05 Dec 2022 16:01:30 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 05.12.2022 16:10, Jan Beulich wrote:
> On 23.11.2022 16:45, Roger Pau Monne wrote:
>> @@ -807,7 +822,21 @@ void __init efi_multiboot2(EFI_HANDLE ImageHandle, 
>> EFI_SYSTEM_TABLE *SystemTable
>>  
>>      if ( gop )
>>      {
>> -        gop_mode = efi_find_gop_mode(gop, 0, 0, 0);
>> +        const char *opt = get_option(cmdline, "console=");
>> +        bool vga = false;
>> +
>> +        if ( opt )
>> +        {
>> +            const char *s = strstr(opt, "vga");
>> +
>> +            if ( s && s < strpbrk(opt, " \0"))
>> +                vga = true;
>> +        }
> 
> Don't you also want to find a "vga=gfx-..." option, to avoid ...

Apologies - I should have looked at the title of the next patch
before writing this.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.