[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 5/6] ac97: make remove callback of ac97 driver void returned



Since commit fc7a6209d571 ("bus: Make remove callback return
void") forces bus_type::remove be void-returned, it doesn't
make much sense for any bus based driver implementing remove
callbalk to return non-void to its caller.

This change is for ac97 bus based drivers.

Signed-off-by: Dawei Li <set_pte_at@xxxxxxxxxxx>
---
 drivers/mfd/wm97xx-core.c  | 4 +---
 include/sound/ac97/codec.h | 6 +++---
 sound/ac97/bus.c           | 5 ++---
 3 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/drivers/mfd/wm97xx-core.c b/drivers/mfd/wm97xx-core.c
index 9a2331eb1bfa..663acbb1854c 100644
--- a/drivers/mfd/wm97xx-core.c
+++ b/drivers/mfd/wm97xx-core.c
@@ -319,13 +319,11 @@ static int wm97xx_ac97_probe(struct ac97_codec_device 
*adev)
        return ret;
 }
 
-static int wm97xx_ac97_remove(struct ac97_codec_device *adev)
+static void wm97xx_ac97_remove(struct ac97_codec_device *adev)
 {
        struct wm97xx_priv *wm97xx = ac97_get_drvdata(adev);
 
        snd_ac97_compat_release(wm97xx->ac97);
-
-       return 0;
 }
 
 static const struct ac97_id wm97xx_ac97_ids[] = {
diff --git a/include/sound/ac97/codec.h b/include/sound/ac97/codec.h
index 9792d25fa369..a26e9e0082f6 100644
--- a/include/sound/ac97/codec.h
+++ b/include/sound/ac97/codec.h
@@ -62,9 +62,9 @@ struct ac97_codec_device {
  */
 struct ac97_codec_driver {
        struct device_driver    driver;
-       int                     (*probe)(struct ac97_codec_device *);
-       int                     (*remove)(struct ac97_codec_device *);
-       void                    (*shutdown)(struct ac97_codec_device *);
+       int                     (*probe)(struct ac97_codec_device *dev);
+       void                    (*remove)(struct ac97_codec_device *dev);
+       void                    (*shutdown)(struct ac97_codec_device *dev);
        const struct ac97_id    *id_table;
 };
 
diff --git a/sound/ac97/bus.c b/sound/ac97/bus.c
index 045330883a96..6067c04ce4c0 100644
--- a/sound/ac97/bus.c
+++ b/sound/ac97/bus.c
@@ -524,10 +524,9 @@ static void ac97_bus_remove(struct device *dev)
        if (ret < 0)
                return;
 
-       ret = adrv->remove(adev);
+       adrv->remove(adev);
        pm_runtime_put_noidle(dev);
-       if (ret == 0)
-               ac97_put_disable_clk(adev);
+       ac97_put_disable_clk(adev);
 
        pm_runtime_disable(dev);
 }
-- 
2.25.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.