Re: [RFC PATCH 04/21] xen/arm: vIOMMU: add generic vIOMMU framework

[Rahul Singh <Rahul.Singh@xxxxxxx>]

Hi Jan,

> On 2 Dec 2022, at 8:39 am, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> 
> On 01.12.2022 17:02, Rahul Singh wrote:
>> --- a/xen/drivers/passthrough/Kconfig
>> +++ b/xen/drivers/passthrough/Kconfig
>> @@ -35,6 +35,12 @@ config IPMMU_VMSA
>>  (H3 ES3.0, M3-W+, etc) or Gen4 SoCs which IPMMU hardware supports stage 2
>>  translation table format and is able to use CPU's P2M table as is.
>> 
>> +config VIRTUAL_IOMMU
>> + bool "Virtual IOMMU Support (UNSUPPORTED)" if UNSUPPORTED
>> + default n
>> + help
>> + Support virtual IOMMU infrastructure to implement vIOMMU.
> 
> I simply "virtual" specific enough in the name? Seeing that there are
> multiple IOMMU flavors for Arm, and judging from the titles of subsequent
> patches, you're implementing a virtualized form of only one variant.

I agree with you I will remove the virtual in next version.
> 
> Also, nit: Please omit "default n" here - it leads to a needless
> line in the resulting .config, which in addition prevents the prompt
> from appearing for user selection when someone later enables
> UNSUPPORTED in their config and then runs e.g. "make oldconfig". But
> perhaps you anyway really mean
> 
> config VIRTUAL_IOMMU
> bool "Virtual IOMMU Support (UNSUPPORTED)"
> depends on UNSUPPORTED
> help
>  Support virtual IOMMU infrastructure to implement vIOMMU.
> 
> ?
> 
> Note (nit again) the slightly altered indentation I'm also using in
> the alternative suggestion.
> 

I will modify as below:

 config VIRTUAL_IOMMU
        bool "Virtual IOMMU Support (UNSUPPORTED)”
        depends on UNSUPPORTED
        help
          Support IOMMU infrastructure to implement different variants of 
virtual
          IOMMUs.

Regards,
Rahul