Re: [PATCH v2] process/release-technician-checklist: Explain how the banner in README is generated

[Julien Grall <julien@xxxxxxx>]

Hi Jan,

On 25/11/2022 09:17, Jan Beulich wrote:
> On 24.11.2022 20:08, Julien Grall wrote:
> > From: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > Explain how the banner in README is generated and take the opportunity
> > to mention what it should look like for RC.
> >
> > Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> albeit with a couple of nits:
>
> > --- a/docs/process/release-technician-checklist.txt
> > +++ b/docs/process/release-technician-checklist.txt
> > @@ -48,7 +48,12 @@ t=RELEASE-$r
> >   
> >   * consider bumping sonames of shlibs
> >   
> > -* change xen-unstable README (should say "Xen 4.5" in releases and on stable branches, "Xen 4.5-unstable" on unstable)
> > +* change xen-unstable README. Should say:
> > +    - "Xen 4.5" in releases and on stable branches
> > +    - "Xen 4.5-unstable" on unstable
> > +    - "Xen 4.5-rc" for release candidate
> > +
> > +*   The banner is generated using figlet
> >   * change xen-unstable Config.mk
> Perhaps insert another blank line between these two bullet points?
> Or, if they're deemed to belong together, remove the one you insert?
I will add another blank line.

> The new bullet point you add also would likely want to match the
> others in style, both for the number of spaces after * and for not
> using a capital first letter (maybe "generate banner using figlet").
Sure. I will address them before committing.

Cheers,

--
Julien Grall