Re: [XEN v4 07/11] xen/Arm: GICv3: Define ICH_LR<n>_EL2 on AArch32

[Julien Grall <julien@xxxxxxx>]

Hi,

On 03/12/2022 20:02, Ayan Kumar Halder wrote:
> The definition is different :-
>
> In xen/arch/arm/include/asm/arm32/sysregs.h
>
>   "#define __CP32(r, coproc, opc1, crn, crm, opc2) coproc, opc1, r, crn, 
> crm, opc2"   (Note:- it takes 6 arguments)
> And what I have defined in  xen/arch/arm/include/asm/cpregs.h:-
>
> #define ___CP32(coproc, opc1, crn, crm, opc2) coproc, opc1, crn, crm, 
> opc2 (It takes 5 arguments, also note it has 3 underscores before CP32).
Ah... I missed the 3rd underscore. That's one more reason to not define 
such macro.
[...]

> Would you also review 8/11, 9/11, 10/11 and 10/11 before I re-spin a new 
> series ?
Patch #8, #9 needs ___CP32 to be removed.
Patch #10, some of the use needs to be clarified
Patch #11 have a minor comment

Please note that I'm reviewing these patches in between my main work and 
it can take a while to go through them in detail. So please wait a few 
days before asking for reply.
Cheers,

--
Julien Grall