[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/4] tools/ocaml/libs/xc: add hvm_param_get binding
- To: Edwin Torok <edvin.torok@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Fri, 2 Dec 2022 11:22:17 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ItzYeLGm6Ss5mdsWfivCYYYDhHqlM5d+54JYkCtHzX0=; b=GbiVDixO89TR2s+gYYSJIfWET/MRJ1FAYdEmQt3nEjaZpCZowlXa/I3W6R8vMsZlet1A7YBMAvm249GDocqWqAI0DDUlbpPad69NAtwMSxKUzlZJ0sZyav2MxGRCc9E3icCVWbVUJ81OmT1s9/HWjvfZpXJngzpsmYb2KktMPKhFRB6lo54JU/bCX2gOKhaN2khGJzT1WcMRkp6p+zs3s3lM1uWdH338eAuAIJuMmdu7rYaTv6mzYV5UcUN3xylE1FoXGrkCt5UqdWSDa+O1e0Ekegmt3R4mJzGuw+KnYS2YEvxObHCRjFOhycUA5Zs/daZNVXMR3O1/xe3iotU5NQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oXj5oxo9PIf4bdc6VZtqz0BN2PW/zbOxU52CS9Bi+yzXlCUOParf5rtSUjESYsDnXhKVwsNKuxuygC2LmEfZdps01fULB6vB9STlxZirqrhD93/ksDWfg+kbyV6r351+31FYMRzCdIJUEv5ElCx1xxhFb4WtWxNPi3SS4u/WyJsSowSFD6vhtSlSRLuu9lUkp2lDRxoei8vsu7ozg8hwhQMZG3u75gifvrbJ5vtxwnYNVG+F/UXcWc0vXDJ1Yn7EvH6zxqRx/JaHLjr3BwtKhvE0hGe0LSdSmDGaCqDvjqg7PHnDzg9BTRcCeNk1HvUSAczzIIKQAZevRiS6SYA/wg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Fri, 02 Dec 2022 11:22:35 +0000
- Ironport-data: A9a23:d0gp6KAmk/HcdhVW/wniw5YqxClBgxIJ4kV8jS/XYbTApDsj1TQHz WAcXGCPb/mLYmD1etp/bIS1o01V7MOGn9BrQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WlA5ARkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw8aEnUF1Tz dciFRcyNRqqueKKy7aQVbw57igjBJGD0II3nFhFlW2cKMl8BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTK/uxuvDe7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr+Sx32lBN1IfFG+3ux03Vi3mWJMMTY9f2uCn7rjkhbnVs0Kf iT4/QJr98De7neDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJhZNYcIrnNU7Tjsr0 hmOhdyBLSNrmK2YTzSa7Lj8kN+pES0cLGtHYDBeSwIAu4XnuNtq0U2JSct/GqmoiNGzASv33 z2BsCk5gfMUkNIP0KK4u1vAhlpAu6T0c+L83S2PNkrN0++zTNfNi1CAgbQD0ct9EQ==
- Ironport-hdrordr: A9a23:Kcq90q/FN78d9NTF78xuk+Grdr1zdoMgy1knxilNoENuEvBwxv rOoB1E73HJYW4qKQ4dcdDpAtjmfZquz+8K3WBxB8bvYOCIghrSEGgP1/qG/9SkIVyDygdR78 xdmstFeZLN5DpB/LzHCWCDer5LrbXpgcPY59s2jU0dMD2CA5sQtjuRYTzrdHGeMTM2fabRY6 Dsn/avyQDQHUg/X4CXI0BAZeLKoNrGmfvdEE07Li9izDPLoSKj6bb8HRTd9AwZSSlzzbAr9n WAuxDl54242svLhCP05iv21dB7idHhwtxMCIinkc4OMAjhjQ6uecBIR6CChjYou+uigWxa0e Uk4i1Qf/ib2UmhPF1dkiGdnjUIFwxer0MK/GXowkcLZ/aJAw7SRfAxw76xOSGpmnbI9OsMoJ 6jmVjp76a+x3v77X/ADxuhbWAxqqLPy0BSzdL61BZkINQjgPs7l/1OwKuReK1wQR4TLOgcYb dT5Aa13ocGTbrSVQGrgkB/hNOrRXg9BRGAXwwLvdGUySFfmDRjw1If39F3pAZKyHsRcegM2w 3/CNUhqJheCssNKa5tDuYIRsW6TmTLXBLXKWqXZVDqDrsONX7Bo4P+pOxd3pDmRLUYiJ8p3J jRWlJRsmA/P0roFM2VxZVOthTAWn+0UzjhwtxXo5J5prr/Trz2NjDrciFlr+Kw5/EERsHLUf e6P5xbR/flMGv1AI5MmxbzXpFDQENuJvH9euxLLG5mjvi7XrEC7NarAso7DICdZAoZZg==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZBj1QpnPDpN8ubkmTLtnuWN4I965adC6A
- Thread-topic: [PATCH v2 3/4] tools/ocaml/libs/xc: add hvm_param_get binding
On 02/12/2022 10:55, Edwin Török wrote:
> Not to be confused which hvm_get_param, which also exists and has a
> different, more error-prone interface.
>
> This one always returns a 64-bit value, and that is retained in the
> OCaml binding as well, returning 'int64' (and not int, or nativeint
> which might have a different size).
>
> The integer here is unsigned in the C API, however OCaml only has signed
> integers.
>
> No bits are lost, it is just a matter of interpretation when printing
> and for certain arithmetic operations, however in the cases where the
> MSB is set it is very likely that the value is an address and no
> arithmetic should be performed on the OCaml side on it.
> (this is not a new problem with this binding, but worth mentioning given
> the difference in types)
>
> Signed-off-by: Edwin Török <edvin.torok@xxxxxxxxxx>
Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
