[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 07/21] xen/arm: vIOMMU: Add cmdline boot option "viommu = <boolean>"


  • To: Rahul Singh <rahul.singh@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 2 Dec 2022 09:49:04 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HuGsu/DXvbNn5QE6Me3Qc6VNL6RE9kDwHA5Lkf+bjz0=; b=hWEBuXBeVJ8DRUbK/xDetS3ikd163PcUixzpfe+aQpUHrnWdvco3363z38rqT3jG5ohdV2/dKtiCeeLHRrOaFl9J5JLaS8uz9eAmvI+5etpPlKlIDFjCQOcq7O6xwIM+wjq8zm6oP8yJBvovAdrBwfNLqAKOcXx+We6BSQhmCEpuX7ILxY5hM6b5H6Hfwoprt306Vtruzjc+tjn0nC2BScCA3z0TUIVmNz/LTC2d+en2qulveHVP4aujOPWINZy2xT31aJ7mUf/NJoQxpimhhJlRABus9jLxJ2FfWPkbh2aOUQVDd09H+xJDqMO410K4cwZxeVhj6/48FiVwKoP/Gg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lkw/xK5q7mjZV06xgs4LvHTZ1uU0g0t9HOe5wbbd9zGE+5CdT/pqPJfcijouoYaS7xLfkcfV4JfViTOj6De/qIYkq/mDvinKjb3/9hix2rGnn/Fh232pjMi9RMbnMKKJOQUjNRM3iOqiNukEDUOJGM/vWxHB4KRE9uUF/bj4+yDOK+ygeopnRx9wVsZx+vghKlaHDo1+AS+nvJR5MbEGi9PaPGhkNDkr5pnyHRPmcSjlpO7PDdJITpFZLZw67Rr4H0GUA8mXN5uNjcwP9k6aJq+4qtKYU+R+uGSohyqxacWrDyaIA0BUNcHo94aYStcPr/D7LQ0ggtrG2Pj5+qq+AA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 02 Dec 2022 08:49:12 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 01.12.2022 17:02, Rahul Singh wrote:
> --- a/docs/misc/xen-command-line.pandoc
> +++ b/docs/misc/xen-command-line.pandoc
> @@ -1896,6 +1896,13 @@ This option can be specified more than once (up to 8 
> times at present).
>  
>  Flag to enable or disable support for PCI passthrough
>  
> +### viommu (arm)
> +> `= <boolean>`
> +
> +> Default: `false`
> +
> +Flag to enable or disable support for Virtual IOMMU for guests.
> +
>  ### pcid (x86)
>  > `= <boolean> | xpti=<bool>`

I'm sorry for being blunt, but how did you select this particular slot
for insertion, when the whole file clearly at least tries to have options
sorted alphabetically.

Apart from that I wonder whether this actually needs a command line
control, when supposedly this is controlled on a per-domain basis anyway.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.