[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 3/5] tools/ocaml/libs/xc: add hvm_param_get binding
- To: Edwin Torok <edvin.torok@xxxxxxxxxx>
- From: Christian Lindig <christian.lindig@xxxxxxxxxx>
- Date: Thu, 1 Dec 2022 14:22:57 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b9+T4O/LQtmp6z20Q+XpF4+1wKsHOhN1vTCNVzR2E9I=; b=D1CYgkwZuQOjeRMazUmir7UOjJ83P9IzE1oZaFNyghI/Z1YwdHjuX5Ae2nrhgTQK4QfqaLtkIEOaNvlOj5cWGb8wTAw7XXcaHgCgrEv6PuRxF+Q+YXvqz742/u4vbpzGWCQCz+y+2JnQSNzCjOQRwKZQoZkh+V6J4/pCE90u/7+iwRB5i23KR8+uj6bwZ+bthVESjEGyjpF3fpIROzmMXCeE6EOfyCnwj0yhIBUvQYJjR3pTBJ2pviSbicjsHyMAaI9yfp48KTpQftEhHPXgJBd+Us2M++KeEKcTFkpfSaRwCvlJy1Xei7M2I7O+heb43aBTzTOD9FFzOlYb5TJ2+A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HFf9frJtvUbaoS68laOT5Qi4f1a/ZvdfJahfvMLFsmOnJHI25CbBDgGnhFGzIDRlok87ipFR3qL3cWseyd5Sy7DS5GQWyfoJCR6XqECaPaNpH2DY3MsApdYt5yHq0do6pruANCcFPqFVjQlMwsNCyi0UtyqsnUggybCgwz/pp6rLS0xEu7321sdktMzmPwgyl920cfejlT7UPRGOc6P4W7+9g015OS9JSYVb8lghv9vnVvif1jBDZaiK4/tg2+VifrjDrR2LqAYaqzjIXwNPacSeyuEwcu7e2/hhEap+MVvK77RKJmndDrudXDfJQFsb5acjapceCN1TpQsmn3Z2Bg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Thu, 01 Dec 2022 14:23:13 +0000
- Ironport-data: A9a23:W5kEEaqlRIX8GBFHY1BCaP9aJhZeBmI6ZBIvgKrLsJaIsI4StFCzt garIBnTPaqLMWT8edAlbNyzpBsHuJOGn9QxSQI++S8xHy4W9JuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaEzyBNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAD0GUyuMuvuu+oL4VfZSuJocI+bEJpxK7xmMzRmBZRonabbqZvySoPpnhnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeWraYKJEjCJbZw9ckKwr WLc/n/lAxgcctiezzaE/Vqnh/PVnDO9U4UXfFG93q463QzOmjZLYPEQfWKersanrX7uZ+hwM lQG9REi9fIV1VP+G7ERWDX9+hZopCU0S9dWVuE39gyJ4q7V+BqCQHgJSCZbb94rv9NwQiYlv neFls3kLSZiu7qUTTSa7Lj8hSy2ETgYKykFfyBscOcey9zqoYV2iw2VSN9mSfaxloesQW22x C2Wpi8jgblVldQMy6iw4VHAhXSru4TNSQk2oA7QWwpJ8z9EWWJsXKTwgXCz0BqKBNzxooWp1 JTcp/Wj0Q==
- Ironport-hdrordr: A9a23:XbV+tKgXUk3IYQkHY0kAn7CahnBQXusji2hC6mlwRA09TyXPrb HKoB17726OtN91YhtMpTnuAtjmfZqxz+8N3WBzB9aftWvdyQ+VxehZhOOI/9SHIVycygdz79 YDT0EUMqyXMbEVt7eD3OB6KbkdKRu8nJxASd2x856ld2FXV50=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZBOHXzyNRueXKzkCvv/VJ69wZtK5Y7MWAgAAhHACAAAIeAIAABVyAgAABsQA=
- Thread-topic: [PATCH v1 3/5] tools/ocaml/libs/xc: add hvm_param_get binding
> On 1 Dec 2022, at 14:16, Edwin Torok <edvin.torok@xxxxxxxxxx> wrote:
>
> The disadvantage is that we can't pattern match on it anymore.
>
> Although we could have some OCaml code that does the pattern matching on
> another type and maps it to these private integer types.
> However at that point we've manually reinvented what ctypes would already do,
> and we have an additional mapping step (which may not matter from a
> performance point of view but would be nice if we could avoid it).
I agree that this is a severe disadvantage. My method is only useful if they
are mostly passed around but not when they have an algebra defined over them
where you want to combine and match them.
— C
|
