[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN v1] Xen: Enable compilation when PADDR_BITS == BITS_PER_LONG


  • To: Julien Grall <julien@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 1 Dec 2022 12:44:36 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sO00GJ18TMM3c6JJKnNd/bqPxhg09YDK+94ASBBHNd4=; b=OSEry7XcRvrLVkenojpCxG8EiZlWhfCIgKzGPcgsFj0oeU3fQaWpbk0SSHF5gHBSl1hZxUQvAT9aPzUv/NOvTQO28C7CvRFhJi3BSAjoQco1VLhBb7izT79AKi6hfOsPchC0R4aSJZ4t/WNr6FP3Cms5XKw5vFpblPPmjrFACRhYDwlq87MsfnK+As6vvnneQx3kgje4YHcdmm6YA45u2npKBETwYBqYi+bb0Z9encVaB79N+RPUDrydPqkXfGjEuWfA1yDj9jJ/OajU+Aw3EXVdYiP9wAu7eQ2vw4+kPIKKJf+7leOu2yz9D4CtVvDULwpAUBJk5DCKlMTzH4XWEA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GjQPRmm8G/7F0IOToAhXh0V/Oxn9vrrkgstUKstDZq9iWPymBZ2dOkGLKqlSu+xU/WkaLo5C4VZG/UGA4TI2WS0uPpr9iHhCOau+w8PyEsV9xynlp1I5/+wUfpr/76Xm07pFrjGdjrpEt8nFWsC4HP5r4ityRryqwyNTNBuzsNJ+w0EP6zn6KWyWaZfDwXSEj+ERRrqGqmz5GPiifoL/4rqAbN2rlP//R678wtI7GmcrGXDbucKl1nLk2YQNTtK754wPGgbGpK1grtmmJCQdSqm+yJs1ctnTezQ3DWicvkHDUlskiSEABMt6bHJiNsuUrUIP0ijoC4N0J0U4mwCFEA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: sstabellini@xxxxxxxxxx, stefanos@xxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, george.dunlap@xxxxxxxxxx, bobbyeshleman@xxxxxxxxx, alistair.francis@xxxxxxx, connojdavis@xxxxxxxxx, wl@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 01 Dec 2022 11:44:50 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 01.12.2022 11:26, Julien Grall wrote:
> On 01/12/2022 10:03, Ayan Kumar Halder wrote:
>> --- a/xen/common/page_alloc.c
>> +++ b/xen/common/page_alloc.c
>> @@ -2245,7 +2245,7 @@ void __init xenheap_max_mfn(unsigned long mfn)
>>   {
>>       ASSERT(!first_node_initialised);
>>       ASSERT(!xenheap_bits);
>> -    BUILD_BUG_ON(PADDR_BITS >= BITS_PER_LONG);
>> +    BUILD_BUG_ON(PADDR_BITS > BITS_PER_LONG);
> 
> Based on the above, I think this wants to be "(PADDR_BITS - PAGE_SHIFT) 
>  >= BITS_PER_LONG)".

+1, fwiw.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.