[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2] process/release-technician-checklist: Explain how the banner in README is generated
- To: Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Thu, 1 Dec 2022 10:50:45 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=au/SVUP37GbPN4KtC4vztrnIPax4n84nmcvzPryxBDQ=; b=iY7R9ZusQIleGGbpxrZYv/NTx3p3RZnJgR870VFUA2M9Twh1/hIbKTFfGfBQFbccJ23Z14zf41cyIdb53amu1E86PYvQ2llkEa76UvKWh5KZT+3yNHqHgreHjOP0UgOJ5uI0H/4xjd6yIo+crVdFD3wrkjQyo7hKpV+SKxHWoZLjOK3R3vXUf3xmMViRJoU6AFQE902+y/p4hReezEzx95qmYrgxZ62UDeXXcAQnvrx2vXW+uP/hhA6cIcHpny7loEsNRpstdC3/a9z8jW9Yf6W5JM1/PeGeSYuwnxj4v9IUGEqkD9/NMZ+IfIPRlFl2WVSU4dCPDaJfOeemWBttEA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lW/nnohK1x5fbnzUHhXpSDghJ7KvLd7qgGDM0eZlcH7WBoEe/fLpUegAN6gMTas9AFiXtgUdrwuM+ygRyw/o5vcwregDm0v2w1CAu90mqQnTlJYCKIITkTgEJHc6XW8Ca9Y3MjFJhF8JVV8IIva4E+dkP81nCkPTp46i7Tyc/77+OohiLGxzL+R0ZB4azaMYLQHmSIk5YKpsIL/z3ov1wayM2r9CU/a4+2+4Ln74IS/0nVovFBXSsgtFKkRJAqcYI5PLYzZaDUTay/4IpFPNviidubhhtv0E1FLDBDzvn+0OqU5nZ9yRr/YI9NsCxQBxw+NVad8aWVZO7EfLRSf2aw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Julien Grall <jgrall@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 01 Dec 2022 10:51:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHZADhFhRdqD5Su4EO+T+vPnuMlg65PXSeAgAmHn8A=
- Thread-topic: [PATCH v2] process/release-technician-checklist: Explain how the banner in README is generated
Hi,
> -----Original Message-----
> Subject: Re: [PATCH v2] process/release-technician-checklist: Explain how the
> banner in README is generated
>
> On 24.11.2022 20:08, Julien Grall wrote:
> > From: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > Explain how the banner in README is generated and take the opportunity
> > to mention what it should look like for RC.
> >
> > Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
With probably Jan's comment in ...
> albeit with a couple of nits:
>
> > --- a/docs/process/release-technician-checklist.txt
> > +++ b/docs/process/release-technician-checklist.txt
> > @@ -48,7 +48,12 @@ t=RELEASE-$r
> >
> > * consider bumping sonames of shlibs
> >
> > -* change xen-unstable README (should say "Xen 4.5" in releases and on
> stable branches, "Xen 4.5-unstable" on unstable)
> > +* change xen-unstable README. Should say:
> > + - "Xen 4.5" in releases and on stable branches
> > + - "Xen 4.5-unstable" on unstable
> > + - "Xen 4.5-rc" for release candidate
> > +
> > +* The banner is generated using figlet
> > * change xen-unstable Config.mk
>
> Perhaps insert another blank line between these two bullet points?
> Or, if they're deemed to belong together, remove the one you insert?
>
> The new bullet point you add also would likely want to match the
> others in style, both for the number of spaces after * and for not
> using a capital first letter (maybe "generate banner using figlet").
..here addressed (can be fix on commit).
Kind regards,
Henry
>
> Jan
|
