Re: [PATCH 0/4] Static analyser finding deviation

[Luca Fancellu <Luca.Fancellu@xxxxxxx>]

> On 29 Nov 2022, at 01:55, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
> 
> On Mon, 28 Nov 2022, Luca Fancellu wrote:
>> This serie introduces a way to suppress a static analyser finding providing a
>> proper justification for it.
>> The process is explained in the docs/misra/documenting-violations.rst 
>> document
>> that this serie will provide.
>> The tools currently supported are eclair, coverity and cppcheck, but the 
>> design
>> is open to support many other static analysis tool.
>> 
>> The changes are split between the first two patches to reduce the review 
>> effort,
>> the first patch is introducing the deviation process for the eclair and 
>> coverity
>> tools, this is because their analysis system is similar.
>> 
>> The second patch is introducing the same deviation process for cppcheck,
>> modifying the current way it is called from the makefile and improving its
>> analysis.
>> 
>> The third patch is a fix for a tool used for cppcheck and the fourth patch
>> is an example of how a deviation can be applied for some MISRA findings.

Hi Stefano,

> 
> I tried testing this series with:
> 
> # scripts/xen-analysis.py --build-only --cppcheck-html --run-cppcheck 
> --cppcheck-bin=/local/repos/cppcheck/cppcheck 
> --cppcheck-html-bin=/local/repos/cppcheck/htmlreport/cppcheck-htmlreport
> 
> But I get this error:
> 
> ERROR: Can't find cppcheck version or version is not 2.7
> 
> 
> Note that my cppcheck is 2.7.4:
> 
> # ./cppcheck --version
> Cppcheck 2.7.4

Yes this is a bug, I’m strictly checking for 2.7, I will modify it to 2.7.x if 
you agree

> 
> 
> After removing the version check in cppcheck_analysis.py, the process
> starts correctly.
> 
> Also, where is the output html report created by cppcheck-html by
> default?


The html output should be in the xen folder 
[xen_repo]/xen/cppcheck-htmlreport/html but when you specify --build-only the 
reports are not generated, only the build phase is executed.

Have you tried without --build-only to test the report generations?

Cheers,
Luca