[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/5] gfx: improvements when using multiboot2 and EFI + misc
- To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 24 Nov 2022 10:56:33 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8jsLsQCrq0Picplk8ufZMvebnhipSQQ+qeftmyG23SI=; b=Ogo95xLM7omq3W9wS7a37AxKwj4sK7/a7gnosQfVPZ9BJric7nkgpTuL6BRbWlQ9PrjaGt6ryt+L2AeJ37zRz3etSMljsr/I5VpNQJ1uDV/nWEsv3LWteyYQsIERYLlktV0kEYYv5jjWpaNeDIDf+/Jc/b09JIqKreFCaF9UpccSR7s5jZbmoQG9Dyx/EisRe1Zd+wP234WxKfJ34A+SfxPADBMGR5I3w7wx5hFUBUmp/jfqwIojWRafCVsLNdz82rvt++LLkw6sZdTSRpp/LkCVjiPCbpQJGcejlqxtvJP5Ju5ZwUMkN7qaAQIcSMLmxVETS/7640jj/5/Gac+i1w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ALxt2gkS1TShh5eNx35E8SNs2wcjwFVDgK4EFDrGU4JjQnrUupGRSxuk9VZEr78sBJqxCJNc0rtBmD24rcYGgr9cJzFYRjUU4zGW5qSSqu6kW0pWH0srarSs4GmTCJicIqs8CQ5cMbJj0Sm/W+pbgMr4DRdivJEB3+YKzFXBmXeS/GrHaf/CTkQUCnXjSi2OXzeKAQ/P4YtbJqlA4+v/97LVxCt1rz6wMBq/AvjStncnDdwOVvbZk64dUu9OeD7tZiETQdHJCfILrMZ8b3amAHptMjtFgoEbINZG0BEfHjG0hfHJFv+9Ng6pYlnG3Dg1PKIjLScALIkKwTPAlPgeTQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Thu, 24 Nov 2022 09:56:53 +0000
- Ironport-data: A9a23:+AcPn6kpfMRxGmz9fOz7B2no5gxvJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJLCmiAM/+OMGv3fNwlPIvj9hwD78LRzNVjTwE4qC8zQiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5gOGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 eQ+Mg9cZ0invL31z5LldMtl2sF8BfC+aevzulk4pd3YJdAPZMiZBp7svJpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVM3jOOF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8efwHumCNlORdVU8NZY2m2r41Y3VyY9SHywsPaQhGCEY/Nmf hl8Fi0G6PJaGFaQZtz0RRixunOHlh8aRdtLEuc+5R2Ny6zb+AKQDC4PSTspQMwrsoo6SCIn0 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkA9L2UPeCsFRgst+MT4rcc4iRenZslnOL64iJvyAz6Y6 zKXqCkzgZ0DgMhN0L+0lXjcmC6lrJXNSg8z5y3UU3ij4wc/Y5SqD7FE8nDe5PdEaZ2fF1+Iu SBen9DEtLxVS5aQiCaKXeMBWqmz4OqIOyHdhlgpGIQ98zOq+DioeoU4DCxCGXqF+/0sIVfBC HI/cysIvPe/4FPCgXdLXr+M
- Ironport-hdrordr: A9a23:ebvEYanvlbJAypFtu5lQIZNqF3npDfNMiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKOzOWw1dATbsSlLcKpgeNJ8SQzI5gPM tbAstD4ZjLfCJHZKXBkXaF+rQbsb66GcmT7I+xrkuFDzsaDZ2Ihz0JdjpzeXcGIDWua6BJdq Z1saF81kedkDksH7KGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftxK/mHwOe1hI+VSoK5bs562 DKnyHw+63m6piAu1Xh/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtSJV9V6aEtDUVpvjqzFoxit HDrzopIsw2wXLMeWOepwfrxmDboX0Twk6n7WXdrWrooMT/Sj5/I81dhbhBeh+cz0Y7ptlz3I 9Cwmrc7vNsfFv9tRW4w+KNewBhl0Kyr3ZnuekPj0ZHWY9bTLNKt4QQ8G5cDZ9FNiPn74IMFv VoEajnlb9rWGLfS0qcknhkwdSqUHh2NhCaQnIassjQ6DRSlGAR9Tps+OUv2lM7sL4tQZhN4O rJdo5ykqtVc8MQZaVhQM8cXMqeEAX2MFzxGVPXBW6iOLAMOnrLpZKyyq4y/vuWdJsBy4Z3sI jdUWlfqXU5dyvVeIKzNaVwg1DwqViGLHfQIpk03ek6hlS8fsumDcS7ciFuryP6yM9vR/EyWJ 6ISeBr6rHYXC/T8L1yrn3DsqlpWAcjufIuy6cGsnK107b2w97Rx5vmWceWAobROhAZfU66Kk c/fVHIVbZ9BwaQKzLFvCQ=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Nov 24, 2022 at 09:59:25AM +0100, Roger Pau Monné wrote:
> On Thu, Nov 24, 2022 at 06:15:15AM +0100, Marek Marczykowski-Górecki wrote:
> > But to get dom0 display image from BGRT, it seems something else is
> > needed too. Linux complains "Incorrect checksum in table [BGRT]". The
> > only relevant google result I get is this:
> > https://support.citrix.com/article/CTX460227/citrix-hypervisor-acpi-warning-incorrect-checksum-in-table-bgrt
> > It blames firmware. But then, it's suspicious that it's also about Xen.
> > And also, native Linux on the same hw does not complain about the
> > checksum. So, I think it's rather Xen to blame...
> > The table lives in area marked as EfiACPIReclaimMemory in memory map, so
> > I think it shouldn't be clobbered by Xen, at least in theory. I'll look
> > into it later. It's getting off-topic for this thread anyway.
>
> See commit 89238ef7797023f318f82f4f9dddef59c435b8bd. I wonder whether
> the BGRT image region is marked as EFI_MEMORY_RUNTIME, I will have to
> check on my system.
Just checked on my system, and the BGRT image is placed in a
EfiBootServicesData section with no EFI_MEMORY_RUNTIME attribute.
To fix this we would need to change efi_arch_process_memory_map() so
it takes the BGRT image address into account and marks the region
where it's placed as reserved. I'm not aware of anyway to get such
address from EFI data, so we would likely need to parse the BGRT in
efi_arch_process_memory_map().
Thanks, Roger.
|
