Re: [PATCH] xen/arm: Fix unreachable panic for vpl011 vIRQ

[Julien Grall <julien@xxxxxxx>]

On 23/11/2022 15:22, Bertrand Marquis wrote:
> Hi Michal,
>
> > On 23 Nov 2022, at 14:39, Michal Orzel <michal.orzel@xxxxxxx> wrote:
> >
> > When creating direct mapped domU, the vIRQ for vpl011 is taken from
> > the SERHND_DTUART serial port using serial_irq. This function can return
> > -1 (i.e. no interrupt found) in which case we should call a panic.
> > However, vpl011_virq is defined as unsigned int which causes the panic
> > to be unreachable, because less than zero comparison of an unsigned value
> > can never be true. Fix it by defining vpl011_virq as int.
> >
> > Fixes: 3580c8b2dfc3 ("xen/arm: if direct-map domain use native UART address and IRQ 
> > number for vPL011")
> > Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>
>
> > ---
> > To be considered to be taken for 4.17, although direct-map depends on
> > CONFIG_STATIC_MEMORY which is marked as unsupported.
> At this stage I do not think we should back port it for the release.
> We should consider this as candidate for 4.17.1
We don't usually backport fixes for tech preview feature.

Cheers,

--
Julien Grall