[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 1/2] tools/libxl: Fixes to libxl__domain_set_paging_mempool_size()
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Mon, 21 Nov 2022 15:16:36 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mdJfzeZ/1HN40XUuQZpgYB2EBpNQUccpK56mfhXaWlI=; b=PZ4zlYoWQtHUkoiK+CUE0I1DjI3SNNql3Ng161jU2jYePTVXzUS0I0AtnAgxWoXi8WALjEfEQiUkjw9eXPhY2a2VRxNS4jXFY/INqQNqIN6QHXeLJPedEnX0TAlAtL6322KZHA+qMJ/hOAu+fP0I+gRSnEJ0ce17/H3TpWJlGCIvkoGS1Q4ay8VSiLcztANX0DTTiUvnAAIJOz99KDZ7ywmpEcnOz1bGFkxiUHIF/8wu54NGGOZD8XPFTed6VWQ5CDBoV6pI/duvpJymvuDZYIUPXG51AcPX0LPRBFUbZf85pERJfXeeivSkWcY5k/lDLwF+v2cNqkL4aB6ST9qiQw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YyKttmCfBVG7XyYKdHxKfG94+/4Pd2nFrDNtqUi2vPy3WNsqUnneWl83FTd+LVtr27YWt2djWkp3zpl7KyJbQoCSw6268poZnfCcr9ayzoQ2OVS+q9pNdYM1qrA4mFeSncZPp84XFVONsR46Ws826bEbiOC38R47VdLMiB+l2WjCUvLOdvzLrmiRFeT/++eq+8BivhQ2nGJ7EI2+lpwO9ogvGq8wLEt7OwtJe3vrHu4ZkCZDDRtJnjuvgJsIK/sR9B5VDi6a8Fqer1odD0Lr4QLNIvk+/C6Io1fy/b9PIJ7jkrx8RL/NOarTgPW9WzKWDim/dex1jUeeT+36Jr9G4Q==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 21 Nov 2022 15:17:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY/bbT1Aw53rbod0uWYqQTx0in/a5JdG2AgAAIiEA=
- Thread-topic: [PATCH 1/2] tools/libxl: Fixes to libxl__domain_set_paging_mempool_size()
Hi Andrew,
> -----Original Message-----
> Subject: Re: [PATCH 1/2] tools/libxl: Fixes to
> libxl__domain_set_paging_mempool_size()
>
> On Mon, Nov 21, 2022 at 02:37:30PM +0000, Andrew Cooper wrote:
> > The error message accidentally printed the bytes value as if it were kB.
> >
> > Furthermore, both b_info.shadow_memkb and shadow_mem are uint64_t,
> meaning
> > there is a risk of overflow if the user specified a stupidly large value in
> > the vm.cfg file. Check and reject such a condition.
> >
> > Fixes: 7c3bbd940dd8 ("xen/arm, libxl: Revert XEN_DOMCTL_shadow_op;
> use p2m mempool hypercalls")
> > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > ---
> >
> > v2:
> > * Retain PRIu64
> > * Check for overflow
> >
> > For 4.17. This is a low risk change, removes one overflow case, and makes
> an
> > error message accurate.
>
> Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
