[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH for-4.17] tools/libxl: Correct error message units in libxl__domain_set_paging_mempool_size()


  • To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 18 Nov 2022 17:02:13 +0000
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
  • Delivery-date: Fri, 18 Nov 2022 17:02:27 +0000
  • Ironport-data: A9a23:lJne0qjbEDnRF5YiXRy9rAJdX161EBAKZh0ujC45NGQN5FlHY01je htvWmCDPPeDZzGkeN0kYN6/pkxXsceAyYViSQBt+C5hEiwb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6oS5QaOzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQoBgBKRS2stdiVye+mbrBDm/w/E+jSadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJagx/5JEWxY9EglHWdTFCpU3Tjq0w+2XJlyR60aT3McqTcduPLSlQthbF/ z+fpD+iav0cHNXY233eqmKjuszszCXpA6EzTJGc19c/1TV/wURMUUZLBDNXu8KRqkO4QcMZF EUS9QInt610/0uuJvHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpVTA9nJZoH3pwj AbPxo63Q2w02FGIdZ6D3oe6nXSZBAcnF0wLODIgFCQY28Xcgbhm23ojUe1fOKKyi9T0HxT5z DaLsDUyit0vsCIb60mo1QuZ2mzx//AlWiZwv1yKBTz9smuVcab/P+SVBU7nAeGsxWpzZn2Ip zA6lseX94ji5rndxXXWEI3h8FxEjstp0QEwY3Y1QfHNFBz3oRZPmLy8BxkgTHqFyu5eJVfUj Lb74Gu8JPZ7ZRNGl5NfbYOrENgNxqP9D9njXf28RoMQPMguLlLaoXswPBb4M4XRfK4Ey/lX1 XCzKJfEMJrnIf4/kGreqxk1jtfHORzSNUuMHMumnnxLIJKVZWKPSKdtDbd9RrlR0U5FyS2Lm +ti2zyikUgGD7SlOnaJrOb+7zkidBAGOHw/kOQPHsbrH+asMDhJ5yP5qV/5R7FYog==
  • Ironport-hdrordr: A9a23:ZM28DazsAvRosXqsUVGYKrPwOr1zdoMgy1knxilNoRw8SKKlfq GV7ZMmPHDP6Ar5NEtNpTniAtjlfZq/z+8X3WB5B97LN2OKhILBFvAG0WKI+Vzd8kPFmdK1rZ 0QEZRDNA==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

The error message accidentally printed the bytes value as if it were kB.

Fixes: 7c3bbd940dd8 ("xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m 
mempool hypercalls")
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
CC: Anthony PERARD <anthony.perard@xxxxxxxxxx>
CC: Henry Wang <Henry.Wang@xxxxxxx>

For 4.17.  This is a low risk change, and makes an error message accurate.
---
 tools/libs/light/libxl_dom.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c
index b59bbe00bb30..68ad9763b6ba 100644
--- a/tools/libs/light/libxl_dom.c
+++ b/tools/libs/light/libxl_dom.c
@@ -1459,7 +1459,8 @@ int libxl__domain_set_paging_mempool_size(
     int r = xc_set_paging_mempool_size(CTX->xch, domid, shadow_mem);
     if (r) {
         LOGED(ERROR, domid,
-              "Failed to set paging mempool size to %"PRIu64"kB", shadow_mem);
+              "Failed to set paging mempool size to %lukB",
+              d_config->b_info.shadow_memkb);
         return ERROR_FAIL;
     }
 
-- 
2.11.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.