RE: [PATCH v6 05/11] xen/arm: define Xen start address for FVP BaseR platform

[Wei Chen <Wei.Chen@xxxxxxx>]

Hi Ayan,

> > +
> > +#endif /* __ASM_ARM_PLATFORMS_FVP_BASER_H__ */
> > diff --git a/xen/arch/arm/platforms/Kconfig
> b/xen/arch/arm/platforms/Kconfig
> > index c93a6b2756..0904793a0b 100644
> > --- a/xen/arch/arm/platforms/Kconfig
> > +++ b/xen/arch/arm/platforms/Kconfig
> > @@ -1,6 +1,7 @@
> >   choice
> >          prompt "Platform Support"
> >          default ALL_PLAT
> > +       default FVP_BASER if ARM_V8R
> 
> I could not spot the patch which introduced ARM_V8R.
> 

That patch is not in this part, it will be the last one of MPU support
patch series. You can find it gitlab branch's full series.

> Can you rename this to ARM64_V8R ? The reason being the underlying code
> is specific to R82 ie 64 bit V8R.
> 

I renamed ARM64_V8R (in RFC patch) to ARM_V8R is because "Arm64 v8r" is
not an official Arm architecture name. The Arm official name is Armv8-R
AArch32/AArch64. And currently, MPU will only be selected by Arm64, so
current MPU code can only work in AArch64 state. When you're trying to
enable Armv8-R AArch32 like R52, you can remove this limitation, and use
CONFIG_ARM64 or CONFIG_ARM32 to distinguish code between r82 and r52 code.

Cheers,
Wei Chen

> - Ayan
> 
> >          ---help---
> >          Choose which hardware platform to enable in Xen.
> >
> > @@ -8,13 +9,14 @@ choice
> >
> >   config ALL_PLAT
> >          bool "All Platforms"
> > +       depends on !ARM_V8R
> >          ---help---
> >          Enable support for all available hardware platforms. It doesn't
> >          automatically select any of the related drivers.
> >
> >   config QEMU
> >          bool "QEMU aarch virt machine support"
> > -       depends on ARM_64
> > +       depends on ARM_64 && !ARM_V8R
> >          select GICV3
> >          select HAS_PL011
> >          ---help---
> > @@ -23,7 +25,7 @@ config QEMU
> >
> >   config RCAR3
> >          bool "Renesas RCar3 support"
> > -       depends on ARM_64
> > +       depends on ARM_64 && !ARM_V8R
> >          select HAS_SCIF
> >          select IPMMU_VMSA
> >          ---help---
> > @@ -31,14 +33,22 @@ config RCAR3
> >
> >   config MPSOC
> >          bool "Xilinx Ultrascale+ MPSoC support"
> > -       depends on ARM_64
> > +       depends on ARM_64 && !ARM_V8R
> >          select HAS_CADENCE_UART
> >          select ARM_SMMU
> >          ---help---
> >          Enable all the required drivers for Xilinx Ultrascale+ MPSoC
> >
> > +config FVP_BASER
> > +       bool "Fixed Virtual Platform BaseR support"
> > +       depends on ARM_V8R
> > +       help
> > +         Enable platform specific configurations for Fixed Virtual
> > +         Platform BaseR
> > +
> >   config NO_PLAT
> >          bool "No Platforms"
> > +       depends on !ARM_V8R
> >          ---help---
> >          Do not enable specific support for any platform.
> >
> > --
> > 2.25.1
> >
> >