[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: vnuma_nodes missing pnode 0
- To: Jan Beulich <jbeulich@xxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jim Fehlig <jfehlig@xxxxxxxx>
- Date: Mon, 14 Nov 2022 08:53:17 -0700
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G5xEF9WofVQd1cS4v3OPFN8SNzwMy+Tm4AXP1Fjabsw=; b=EDsOdaxgsPLzJ99h0YSLIH58tSPcvjtRqSBOCX8oP0TMv/1H+ypRnPbKXh+du2ZXKOfmNq2gCvtdJaefPZeOH3IlSfoblPLxLLUWncCw0WV6WNJVuWwXtIwqKQ7rBdJTLqznzmX4yPrxCpx5R0MHDwsHwuncDDAfDm7EuxZcmXdEEfSuGB9Fj80IfD8G+gTDc33MMl63bVlEGmYrP6slBFfomHArVJ4y97H1UfOHHpLQnEfPep8B0elTM2AJOEK/ojECu179B5ilmo1O7vC9DTLWjW0N4D9VffxeQ8CpnAllbJiUTu7DJQfOOCVLiReUz0UHz1PE02PcMOg8WevlEA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q6TEHFbJzBod3q8943dNCoY7HinDI2SCtjIZKU1dxwf7I0NQFHguhZ8nFdD5K2um9lwXOOIOhJ0Kl+RXpAIGVDV8WE2gZgNy/0B6L+vR15OG2LWC3WHKChxTldKXIVkc/TLZk9ILg1PazvJ64sS4D+gkFwm7lClbc+a7vaA4QukHEqgh1res9I6RCTuiHFwH2tRHyqPDLX9x9TrTN2ASgSo8S3o1ZcPslYAlUr1HaiI5uE1z1mo+hJ6/rWdwQP7HlnOFA3DjYgm+Ie0Wdi9BKwK2azOk9UtR+bcbrgFBZBpuhHj3Y/cH788U6/gDQ9soikvolzcAhhoGus+gBSdoHA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 14 Nov 2022 15:53:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11/14/22 01:18, Jan Beulich wrote:
On 14.11.2022 07:43, Henry Wang wrote:
Sorry, missed Anthony (The toolstack maintainer). Also added him
to this thread.
Indeed there's nothing x86-ish in here, it's all about data representation.
It merely happens to be (for now) x86-specific data which is being dealt
with.
Internally I indicated to Jim that the way the code presently is generated
it looks to me as if 0 was simply taken as the default for "pnode". What I
don't know at all is whether the concept of any kind of default is actually
valid in json representation of guest configs.
0 is definitely ignored in the generated libxl_vnode_info_gen_json() function,
which essentially has
if (p->pnode)
format-json
I took a quick peek at the generator, but being totally unfamiliar could not
spot a fix. I'm also not sure how such a fix could be detected for testing
purposes by libxl users like libvirt. I.e. how to detect a libxl that emits
`"pnode:" 0` in the json representation of libxl_domain_config object and one
that does not.
Jim
|
