[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 4/4] xen/arm: Correct the p2m pool size calculations
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 11 Nov 2022 10:11:39 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=htO6k5tkRGlYJygU8RCCLu2Lydw8uEvKCH62asuzYpM=; b=b85f4QFdov3mXXimbAUUgmUFbraE24/68hfISONHL5KNkLK760CDZgZtAF6nTKNGpZ0uot/fuir6MwCzX7Y+S4CTgoyNnppRbbKeUTUT0qPAvpKhWiF8FXcn8tt3ZPvcUoNEt9zQnT+PV/NE13Uzo9YCqHsG/RiXryzyUCAUb98gLhep1pzrcDuvIKHmARis9uXoUrqV4UbvI/PgtpnvoeysYDX9yK1NyvThdKL81gDIyHoqW9wpWvyVCtd7Tbq+pMtKk9oHRvGPsqkNBqSHuynrJb1YfUt6uwUviGknspQe0wuz7SHHw+zWFTZ01VO/T4xCW/vgp7OcVCqYcX3jmw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=htO6k5tkRGlYJygU8RCCLu2Lydw8uEvKCH62asuzYpM=; b=iuPUEQSNFOp795LXvR37BB2ZgrvZLMcKMTFQxNrdH2Vzuyg/11JUsnZTD1Ymd/APrSxK+m5GUBAUIlDymVDI/JVYm08F7Ta0sYJmqJhCwPgH+V1mD2OYaOYs9GczTDU25COwJwNlLIVhKTKPa1+92ALmNBbtBvaMEmteR8XUEFNl59hYIaUUyKeZIMQIoGEEZiYi8nqVj1Tw4xJqX0ixrot0+KS+d5HhEfD+mu5aswAG+Eal1eionnNMM5ykSLdRvQCc2KhkrnwGdwQUMMGg32CKIUs2ae7313xK1WaSSIvX0T3XwsMjdKfUtiwe1kzMs6Z4WN9gnfHVSMFpzT57WA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Bh0mxMs/bOoF/UIaI/o4EwQDoNUpRcVG6JBdahEsrlqr3wTshpT6l4duFS3DckZgi0wDOZStmtdZLjijAQW3zRdTVHgYECn5TwAKxYZhl5VQr0rvsw3KuLR6135w6ltHJbSKb4lKpHsohrpenQD6+0euvgLpaxBtsZX0VWSbbODGO4lT6wkYCeY7Y0tDK3+0mL0G774b8Psf1AI6jfpH3FyPfkcUG/pBw16DyMfIbAQWSeeYxL95s7gRCinPjeWysjZo6Gw+LtxuDa/71tk73V84ne+0SztlicwPcYjCJXPoCwdiZBcEbydSDHPdHM0QtJ2c2cW8S/Ia6f/UZDWjhw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MrkeOGYzDFJ82QcMrQ2e+KqyBs62/ysE8jSQUx643nSduTW0SIC0tvdFHbWkeh4fwYr0lajnIOFA7dxFtLzwflDuMDW4u5OtWWCvR196gST8Y4RlztwCM+Z18625Yr2kjW4Okq/4TS46f0dfQY1PvOtEz15ZlKsHE9uu0eKjKawsu7mlq1H9PgFCym9hJ4hQn8SX97jUIu6RBsqyByQQ79hIo5ANl/P6tMCq1nLV0O9LOek4SjHw+ttwIUROO2Rcjyi9fAszlVxSPmJAyzPUMa4Nr/aoFMJMLs23Lw9EOSoS5z6w9O/zuI38OSosVrkVKFKPgdXDyus92bLdnC3fWw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen Security Team <security@xxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Fri, 11 Nov 2022 10:12:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY6SStZDoQezt9v0CQXVr6uHbE2645mSbA
- Thread-topic: [PATCH 4/4] xen/arm: Correct the p2m pool size calculations
Hi Andrew,
> -----Original Message-----
> Subject: [PATCH 4/4] xen/arm: Correct the p2m pool size calculations
>
> Allocating or freeing p2m pages doesn't alter the size of the mempool; only
> the split between free and used pages.
>
> Right now, the hypercalls operate on the free subset of the pool, meaning
> that
> XEN_DOMCTL_get_p2m_mempool_size varies with time as the guest shuffles
> its
> physmap, and XEN_DOMCTL_set_p2m_mempool_size ignores the used
> subset of the
> pool and lets the guest grow unbounded.
>
> This fixes test-p2m-pool on ARM so that the behaviour matches x86.
>
> This is part of XSA-409 / CVE-2022-33747.
>
> Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M
> pool")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Hi Arm maintainers, may I ask for a reviewed-by/ack from you for the
correctness of the code in the release? Thank you very much!
Kind regards,
Henry
|
