[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN v3] xen/arm: Enforce alignment check in debug build for {read, write}_atomic
Hi,
On 10/11/2022 00:00, Stefano Stabellini wrote:
On Tue, 8 Nov 2022, Ayan Kumar Halder wrote:
From: Ayan Kumar Halder <ayankuma@xxxxxxx>
Xen provides helper to atomically read/write memory (see {read,
write}_atomic()). Those helpers can only work if the address is aligned
to the size of the access (see B2.2.1 ARM DDI 08476I.a).
On Arm32, the alignment is already enforced by the processor because
HSCTLR.A bit is set (it enforce alignment for every access). For Arm64,
this bit is not set because memcpy()/memset() can use unaligned access
for performance reason (the implementation is taken from the Cortex
library).
To avoid any overhead in production build, the alignment will only be
checked using an ASSERT. Note that it might be possible to do it in
production build using the acquire/exclusive version of load/store. But
this is left to a follow-up (if wanted).
Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
Signed-off-by: Julien Grall <julien@xxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
I have pushed this patch in a branch for-next/4.18 on my public repo. I
will apply the patch to staging once the tree re-opened.
Cheers,
--
Julien Grall
|
