[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] x86: Check return values from early_memremap calls
- To: Ross Philipson <ross.philipson@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx
- From: Dave Hansen <dave.hansen@xxxxxxxxx>
- Date: Thu, 10 Nov 2022 08:07:53 -0800
- Cc: dpsmith@xxxxxxxxxxxxxxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, bp@xxxxxxxxx, hpa@xxxxxxxxx, luto@xxxxxxxxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, kanth.ghatraju@xxxxxxxxxx, trenchboot-devel@xxxxxxxxxxxxxxxx, jailhouse-dev@xxxxxxxxxxxxxxxx, jan.kiszka@xxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, jgross@xxxxxxxx, boris.ostrovsky@xxxxxxxxxx, andrew.cooper3@xxxxxxxxxx
- Delivery-date: Thu, 10 Nov 2022 16:08:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11/10/22 07:45, Ross Philipson wrote:
> dt = early_memremap(initial_dtb, map_len);
> + if (!dt) {
> + pr_warn("failed to memremap initial dtb\n");
> + return;
> + }
Are all of these new pr_warn/err()'s really adding much value? They all
look pretty generic. It makes me wonder if we should just spit out a
generic message in early_memremap() and save all the callers the trouble.
Oh, and don't we try to refer to functions() with parenthesis?
|
