[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs
- To: Henry Wang <Henry.Wang@xxxxxxx>
- From: Edwin Torok <edvin.torok@xxxxxxxxxx>
- Date: Wed, 9 Nov 2022 16:55:10 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yR5paNWa+S9Aw2macB++WyQPB95hLTRGgA3wffIcHwk=; b=jwF3A9HezemY1NShsgdSXCtST6C9iTcGINHq5s/7O6t2NUx/64zOM1dBfP/eLPiALClWVauELuztIKDFETtxl+uJxZbKgVm9SRXrnyVAc84yp0ujlpON8sFEvsyFI2Xe2kxbuyNhrLEnpzLag5m4eZJfTKK53zACuVa7dMWH+3qnDNdwzlo1XXMWLdZ5G8KrbEdx6+E29+qmZVqYNmokMyS4moKfWcauMEVnQfpJ6TkfTIx48CQK2x6IourAOCjcakm8eyT7yvq7oEQyfHQNh0nlemma51PCi4SxMVtCVg29nseM/6dkdBKBrpMRUqFBc+9gUn1WEarPpHglnKK2oA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XKTlLx8q4w1b+mybl7U7t4qqBvv6LQkb9391w/OK28iZvasLz61bO8PAxlzNJcgDQ4B/C5OvUK2zzaNG8OJtE7N4SyO153tGH0njKclhA3F36Sr6e1kis/E8uoapfISAiVJKIM6aRm8i04bnJum0mrQyGls8E+bgqOWGJ1huzyqydJaG0FAjkzYYloJX39889BHfKMcSjrpS1m5gwaxL8VGRvN8qfOqJSyqPShcPgFIvs4XI42UKsGIbEX3KB2RBChthLMFkVagaTnH24QfHlgais/tvrDMK50YjTAGligZAycv2+c5WclSgsmct3mZ4uUE/FBpRmWKPtutdgsg3YQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Wed, 09 Nov 2022 16:55:31 +0000
- Ironport-data: A9a23:e7HdzKq9V3eokdpFyPLKYE9E7HpeBmLbZBIvgKrLsJaIsI4StFCzt garIBmDaP6ON2HyfdFzYIq3pkhT75Hdx9UwHARvqHo2ESoS9JuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHzyhNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACFUc0qYosKN+6imYK5mv4MgduOxPapK7xmMzRmBZRonabbqZvyToPV+jHI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeiraYSFEjCJbZw9ckKwq 27Y/mK/HhYAM9+3wjuZ6HO8wOTImEsXXapCS+Xipq830DV/wEQiKQEOBVqYnMWooXyeC88GA UMkxTQh+P1aGEuDC4OVsweDiF6JuAQNHeVZFeIS4RuIjKHT5m6xBHUATzNHQMwrsokxXzNC/ k+EmZblCCJitJWRSGmB7fGEoDWqIy8XIGQeIygeQmMt79D9rakpgxnIT9IlF7S65vXqHRngz jbMqzIx74j/luYO3qS/uFrB0zSlo8GQShZvv1uHGGW48gl+eYipIZSy7kTW5upBK4DfSUSdu H8DmI6V6+Vm4YyxqRFhid4lRNmBj8tp+hWF6bKzN/HNLwiQxkM=
- Ironport-hdrordr: A9a23:5C2dOqBzWSSiC8rlHegPsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuKKdkrNhR4tKOzOW9FdATbsSp7cKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUaF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlml9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4gow3TX+0WVjbZaKvi/VQMO0aWSAZER4Z 7xSiIbToZOArXqDyeISFXWqlDdOX0VmgLfIBej8AfeSIrCNXwH4oN69PxkWwqc5Ew6sN5m1q VXm2qfqppMFBvF2D/w/t7SSnhR5wOJSepLq59ts5Vza/poVFZql/1owGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlIhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OFDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowVLau3iefPFm8Kc7gSwlGl/NLAgF4vsul6RRq/n7WKfhNzGFRRQnj9agys9vcPHmZw ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY84fA+Ym2JRve3kKJcIO1APAKeK41MEgAgACx3ICAAML3gIAAI/qAgAAH3IA=
- Thread-topic: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs
> On 9 Nov 2022, at 16:26, Edwin Török <edvin.torok@xxxxxxxxxx> wrote:
>
>
>
>> On 9 Nov 2022, at 14:18, Edwin Torok <edvin.torok@xxxxxxxxxx> wrote:
>>
>>
>>
>>> On 9 Nov 2022, at 02:40, Henry Wang <Henry.Wang@xxxxxxx> wrote:
>>>
>>> Hi Julien,
>>>
>>>> -----Original Message-----
>>>> From: Julien Grall <julien@xxxxxxx>
>>>> Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add
>>>> 'make format' and remove tabs
>>>> While I understand the goal and support, this seems to be a bit too late
>>>> to do it in Xen 4.17 (we are only a couple of weeks away). At this stage
>>>> of the release we should only do bug fix.
>>>>
>>>> This is clearly only a comesmetic change and there I would argue this
>>>> should be deferred to 4.18. That said the last call is from the RM.
>>>
>>> I agree with your point. I think maybe defer the patch to 4.18 is better,
>>> given the deep freeze state we are currently in.
>>
>>
>> Indentation can't really be trusted to humans :)
>>
>
>
> It might be better to consider oxenstored unsupported in 4.17 at this point
> and try again for 4.17.1 or 4.18
Ah I see that 'Live Update' for oxenstored is already marked as 'not
functional' (I indeed remember seeing a patch to that effect),
so looks like nothing else needs to be done here for 4.17.
https://xenbits.xen.org/docs/unstable/support-matrix.html
I can try fixing that up for master, 4.17.1 or 4.18, whenever that opens.
Best regards,
--Edwin
|
