[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build error
- To: Edwin Torok <edvin.torok@xxxxxxxxxx>
- From: Christian Lindig <christian.lindig@xxxxxxxxxx>
- Date: Wed, 9 Nov 2022 13:50:17 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MAT6oJKM4Vhge+KjIDp8bK+2CIxuuCWbsVcoSvOAKts=; b=bKMKt3aoxRVv7k2UKysP9pXBC/DXwlN/v6DjFU/SnF39eUgnY80h2oPkYljmSxGqmpx72QfbDJgX7R8cWYWW/H5//Fl7ddyJmsIUkAGmKEg475YabMGa8cYCe3KISsW4vCa0DKjW5eF+vtvCLc5F82Acs2JwpS+DZ39M74WZi8Gt3nR8FKSDWEjsNPefWk1jeSvEOsI1NvGzCScqNpiXiG7XLgstWFJWwRQ9KJi25LO0sr29JB9qms+7nzrsTijnltN9hk3+0sOeYyhgv02BvITj2jJYZJw6PV5oJKzPLhdzolLnWniEJP7Zq9nJz4R/4cdhRabLsqdoJuA61H0LpQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VONodtDGNnG7/+CbQw6jhZMnV9YXli9UbS2y4Hqda8P9QbnDZj42QMPKMguljZ5yb4pNytF2mgUcuR5fl1lvhIcWJ14Ukeic1VLFWu28yScsB7ZGgrohJkL+4kosFlr0SaUZHC9+/gp+ztaxTYiHlw2btSot1N0u83Mnzm5Q/kIXtI+BreA3z+ilYUprqqJG7n0q/MRm4ycQYHRvVKVOYwvbMfYukqO3qCp8fDWW6IkunZ5Mjx3STccxXPURBkKQzvpNr7R8ORyDRbE5EbCOw64ZDuJVmOVDVxol/9MZXT/Q3Z7xHu5Cr6+Ac4+7MMx+3qyZpZlEdiKnEq1pK1m1iw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Wed, 09 Nov 2022 13:50:28 +0000
- Ironport-data: A9a23:F8JHJa1o05ABlvlN8/bD5exwkn2cJEfYwER7XKvMYLTBsI5bp2FVz DAYXWzUM6mIMTenL4gjPYznp05Uvp+AxoQwSgttpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVmNKgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfH0BS6 Pc4NAw2TTupueKG2qy7Rutiv5F2RCXrFNt3VnBI6xj8VKxjZK+ZBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxpvS6Pl2Sd05C0WDbRUteKX8ROgkeRo CTC/mL1Ax4yP92D0zuVtHmrg4cjmAurBN5DT+Tjr5aGhnWJxTIvBRAXCWDg/9i5kVOiY/NGM 3ALr39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOlMIwXy1s6 VaPkPvgHzkpu7qQIVqR/6mZhSm/Mi8UKSkFfyBsZRQBy8nupsc0lB2nczp4OKu8j9mwHC6qx TmP9XI6n+9L0ZVN0Lin91fahT7qvoLOUgM++gTQWCSi8x99Y4mmIYev7DA38Mp9EWpQdXHZ1 FBspiRUxLlm4U2l/MBVfNgwIQ==
- Ironport-hdrordr: A9a23:U6MaSKppJtOJsTsgUBiP4cAaV5udL9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ku90KnpewK+yXcH2/hqAV7CZnithILMFu1fBOTZslrd8kHFl9K1kJ 0QC5SWa+eAQGSS7/yKhjVQeuxIqLbozEnrv5am854Hd3AJV0gU1XYcNu/tKDwSeOApP/oEPa vZwvACiyureHwRYMj+LGICRfL/q9rCk4+jSQIaBjY8gTP+wg+A2frfKVy1zx0eWzRAzfMJ6m 7eiTH04a2lrrWS1gLc7WnO9J5b8eGRhOerRfb8y/T9GA+cyTpAV74RGYFqewpF5d1H3Wxa0O UkZS1Qe/ibpUmhOV1d6iGdpjUImAxel0MKj2XozUcL6PaJOg4SGo5Pg5lUfQDe7FdltNZg0L hT12bcrJZPCwjc9R6NruQhx3lR5zWJSFcZ4JkuZkZkIP0jQa4UqZZa8FJeEZ8GEi6/4Ic7EP N2BMWZ4PpNa1uVY33Qo2EqmbWXLz8ONwbDRlJHtt2e0jBQknw8x0wExNYHlnNF8J4mUZFL6+ nNL6wtnrBTSc0da757GY46MIOKI32IRQiJPHOZIFzhGq1CM3XRq4Tv6LFw/+2ucIxg9upHpH 0AaiIsiYcfQTOcNSTV5uw7zvnkehTMYR39jsdD+pN+prrwALL2LCzrciFdr/ed
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY84entqxHr8vmGEKYGJ5naAn9nq42nVMA
- Thread-topic: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build error
Building
with Dune in release mode fails with:
```
File
"ocaml/xenstored/store.ml", line 464, characters 13-32:
Warning
18: this type-based record disambiguation is not principal.
File
"ocaml/xenstored/store.ml", line 1:
Error:
Some fatal warnings were triggered (1 occurrences)
```
This
is a warning to help keep the code futureproof, quoting from its
documentation:
Check information path during type-checking, to make sure that all types are
derived in a principal way. When using labelled arguments and/or polymorphic
methods, this flag is required to ensure future versions of the compiler will
be able to infer types correctly, even if internal algorithms change. All
programs accepted in -principal mode are also accepted in the default mode with
equivalent types, but different binary signatures, and this may slow down type
checking; yet it is a good idea to use it once before publishing source code.
Fixes:
db471408edd46 "tools/ocaml/xenstored: Fix quota bypass on domain shutdown"
Signed-off-by:
Edwin Török <edvin.torok@xxxxxxxxxx>
---
Reason
for inclusion in 4.17:
-
fixes a build error in a previous commit that is already in master
Changes
since v2:
-
new in v3
---
tools/ocaml/xenstored/store.ml
| 2 +-
1
file changed, 1 insertion(+), 1 deletion(-)
|
|
