[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.17?] x86/pvh: report ACPI VFCT table to dom0 if present
- To: Huang Rui <ray.huang@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 8 Nov 2022 17:33:19 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/yXhiocv9/KQB7pT6PT/yrGtCj+DEwJvZc10DZj/Sc8=; b=kYnStpP3H5c3yFijd38ctoNEI2sheZMzcX1GEjYKRNhd3sE9jab/LlVnmI46Yikintf4g3Dm3sYnquu+EPeqMLHMok2Y5uGXN6Z6jTqcjKIDweXun/eoHJ8QaLLZXFxhW17XwWiR5eMQLezg8GnHsoYum/vwTcH2XSKNehLxHeGL6kFgvoQ4SxxbHbdoZyxxl0nd5BadljhlG7UqJOl1DbE/R32XFwXLsgNu8VVIN4eqDoHOT8yK9kn7JFzIfI+hEM2TIN/JAFHHO9XAeC6chW27xclGY7c4q2TiLjS+KhNZwgjcgEjuv3uoAAhSu2jq3AunvdagMHfssEhhe0+lyw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wa78eJADXs9E0JlYqSvj9znkRNEkkyO+Rqidoojind+knER4GPUHUM+oOKzkVcwWXqQVLTrlEKWhD8z6Oboz/eN+0xhSgNloQKfxWrVdap+HE/VsvuXCFQP9zNMSfyn4EzdC7c8qBtz4tBgw8Wg2Ql9FRosYYI0eOJ5CAucsCw9H5Q2r/26ynmZEygWWxhDJ5j+3Hv9OaYfharW8khnJmIyKPLT64fMEE8tnkhgZScChQ9EgjZqkOK70apZDXJ2imacZIF6scf8VsYbM0U96AKxEnb/kA7DtEhT8lFTGGjTjpTRz7gEgRbWlSw+bKUEbvN3yPycFZKhbnZPpCFMiZA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, "Henry.Wang@xxxxxxx" <Henry.Wang@xxxxxxx>, "Deucher, Alexander" <Alexander.Deucher@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 08 Nov 2022 16:33:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08.11.2022 17:16, Huang Rui wrote:
> On Tue, Nov 08, 2022 at 11:56:17PM +0800, Jan Beulich wrote:
>> On 08.11.2022 14:55, Roger Pau Monne wrote:
>>> The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image
>>> from the firmware instead of doing it on the PCI ROM on the physical
>>> device.
>>
>> I can't find any mention of VFCT in the ACPI 6.3 spec, nor anywhere
>> under Linux'es include/acpi/. I don't mind the addition that you're
>> doing, but there needs to be a pointer to a sufficiently "official"
>> spec.
>
> Thanks! In fact, this is defined by AMD atombios (VBIOS), we have up
> streamed this in the Linux kenrel. You can see more details here:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/amd/include/atombios.h
I can see about two dozen lines at the bottom of that file, with
effectively no helpful comments at all. I'm afraid I don't view
this as "more details", let alone something replacing a spec.
There at least needs to be enough to be sure that "VFCT" is really
firmly reserved for this and only this purpose within the overall
ACPI table name space.
Jan
|
