[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH][4.17] kexec: restore hypercall 1st arg's type
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Tue, 8 Nov 2022 01:05:46 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jqa2RjtQWWG/e0fAb9DGuzRMYmH/1iSHfNHPjH8ugbQ=; b=DbTr41ir91N++DEvRYn8Wl7h4cFn+MJtxB5PjDVVY+4OXMTmqvmN4WBQOxKHIacT5wT4ORzEJR5nrK7cJEp8pNNGfSLQECNNBUNl3fDUfzfNZzjspEw4KbGgKMRRa28rIImWyrz0CK+a0ApqSjUs8YJlwHsQxQ0WNMvrtJF/BjJY7H1/GQ+99nbp45jtQ0S5CbO8hu2/8CSIrz0NRbJS8jr3bHe9CwWuI/JVuPAq2l2EZCk8VcWHUaVNzIXnHqP/HmLK9fqaF6MsC1cD7PmxyT2701JchJICgQwv/a0dIdqpcUt13mhUtvLXIUMU90C0MqL5/P5rC/Y4Hknp0I8elA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jqa2RjtQWWG/e0fAb9DGuzRMYmH/1iSHfNHPjH8ugbQ=; b=Af4+e8pcKaVCDjoTYI+ROh8r+xICcU7UIVgfp8Hpq6ZF5u3jrrt9cwNwX/7wCz2RMjMfbfvEZaPbIybfpsya/CSJbK+v9R+sX6paxE031ZJhKqs6U0LUw7rtnvBUADH7hhuGNnGzPq0TUdilijFdzNFH0e1XTGLxIubyvYv9sgd8USkGLlQFgRYFmJ3dLb2ekeXKVeJBPywXpSgUu3YH0QE7ihzw8ntuUHWhDLCjhpc0gOb0nohDmt6nQcuaW5Z6tu75ptf9PiNqaHgCUeuZlzYnraIuuROdR4TiRMAS07KLoP+HUoHkS/LX7Xr4SnSFIpok9ToZhSvYjSRpJVHGDw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=lvF9Epvz9dxyyoTbNOXJSvEUPvgnumjag0leTRCk1fa5WTBCFSdObw6etSfnCOuUx6Dp+1rIMbvZsfYfPkROCqDJU34zXag0WoRkQv80XDFVFsqQMvoZw2v2a4wBg6xdSlCS01H7E/HGDWzOTFHmiU6yr2f5CSYPgyo9WDb5RvQIYMvimEwvuIAmdWMM9DvXD0wnnd7R4FtEYxkA4lh9jxxZTjlMY1PM5Ks6eFsudPQMasrHwaMm2fuYEQprDXpxlJIEhOuUJBNufTgnAzYRtxwvqWIO1SANQUB6+IWn0YuBUUqMj+DLDf8tucq6cFD6Fa+M8SQZdWxcN2/2N07imw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OeVjHBswMsT/u3LLLihGGAAG/X/vAVcPiSk5lem8bON+YbHm9uYhA0cGynRbzr9nKqXCU9L1d2ofLsDP0+aZxW410kt6nt+tQJVW0n+4aEOYNe0CKxeAYnf8tRxnVw1ecJXR25+CXxPWyzik5RBwE3NPHiBTvlmtzOW2DVdelu75I2JhawRIIKMhSfh2NlG3gkGpkVoQK14G9EHhDXRuRFF9rN9hSw1jwi6FzuD74mrXwdxGxiywca4RkqqWanUAtpoxlYYprSuKDDhqICNjZDUFXjizv/hhBn7VKxeGZrHVGk4ppM5GHDWjDTr3O5OoP77aP4uu7J6t+pBv2yeeag==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 08 Nov 2022 01:06:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY8rrrC5MnTfe7JEO9u4gvJODJ2K40NucQ
- Thread-topic: [PATCH][4.17] kexec: restore hypercall 1st arg's type
Hi Jan,
Thanks for the patch.
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Subject: [PATCH][4.17] kexec: restore hypercall 1st arg's type
>
> This reverts a small part of 7e21b25059ed ("xen: harmonize return types
> of hypercall handlers"). The change from "unsigned long" to "unsigned
> int" for the native handler function meant that previously invalid
> values became valid. While perhaps not a significant issue, strictly
> speaking that's still a change to the ABI. Don't go as far as restoring
> the compat entry point's type though: That one can't have values passed
> which don't fit in 32 bits.
>
> Note that as a side effect this fixes the invocation of
> hypercall_create_continuation(), which by mistake wasn't adjusted by the
> earlier change.
>
> Also take the opportunity and correct the respective comment in the
> public header. (The way it was it really supports that it probably was
> pointless to use "long", but that's the way the hypercall was
> introduced.)
>
> Requested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
