[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 7 Nov 2022 11:53:10 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RHjIOY1lQCDI06OJXzFqzGEEUHu6UGB33E623c5gWuA=; b=P8NFSBknvabDudjypyMoX0vexGuw5XSxnkm493S7ki9btIip2CsGAteoRph7MamTseTHZzUy+NEH3MokAfQwHvWRjPik+xYs1z/nZaS7YIR5MQZYhBkukDsJ2LcD32IRDHsQVf+wQzjwBfwRjNiy1UMIE54Ucj4vcxZLKDklhVTVoLSrsalzDtWAPj3tAvKRlniJ4MSvGRoZKwDezkuYa5rbGOO2Y0uMAgPUtP3LfCZjelgBlZn93Jpq6Vxc07fRnrvqEme/pzT0NC/3g4hk6Uj76LbZhzmv2Hxo98PaQOWHogzMv5XluX9XMtfMlJ7WZzfrMe+hspL1+9qtIPoMAg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RHjIOY1lQCDI06OJXzFqzGEEUHu6UGB33E623c5gWuA=; b=gif6V1WQIyJlZ94W7WjxnjKsmn+lXkU8pRCaATN0Ew9gTfqhx11RGEE/6FzBPpQxwFFEEa3T9ViwDRCgfOHgESnbKDYlcIHmcfCs0qCbkIMXazLSMnjA4hJkv7AaL4XVEvqkOh/h05+EiAZcntO1IVttNs/r+PfTkouJ/K77r3qIlrDQrjLgV7vh+WSgTFPayz/t+7ZStMVb8XTXgGRwaR684XooH49v6WM9t3FGBVNoaZD8KB9YniiEylXOsgXJqLf/hBM8xQn7clzJihi3xO11E3GKvA9xuVVZUKeicrQZxY2aKHALA4u/sVSaB0RZT+uNxm34CK5lQNGYu/xcwg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=eNCSNHWW/oy0QCNfk+EIIvJ3J9U2sodAPJWYU/2ilHotGkEk199GwtuymeiVzatIsarzUuSSIX91QJ+VuMO10/suinPBJiqcFC7v01+MHcY6XzHpMKPxlYS1qdmsZ+Lg0lcWKuo4dkdksLHe0fe+Dz8+ElRthh4sT8GZog3TsRyPUc7TCWaoldr0xNLKVvTk8n3mYT8ieAWACqoCqMEKwpxi/+UEQfhGgRfirIxjKNpPuASMrlbN/2EvvQo8upDktjW0wjc7rflXhW/4Ulvo+4GR8sPFWLFNG7QTTg3wh3XNldo99fsVk0y/lER3WIlPJp264Z2GyU1qbOJh99dcNQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l+QB0d6G9qsJNGJRgNO8uDpQHandlJa0I0oJuLBeX7QHWVfgq0y439wY21W8JnEEVPu0qK+c1FGam01EAbf6r4nxUncQEDt6FhlciLD1d+qUl8Q6rIqr9QrBlOZHOyFSfwgdWQGijWjDTbDPPLl5VtY8zbhL3FpN2oCaLZK0HOEUPsRfa5FohXBqjmsCD2bZ7Nb96IlxREE8YG+t+TStMocwCs6S3dDk/kwxer6dZf+apdjbVBMlTA5R+q81l38ZUxklVuPaqgANpddI4+a4KJaJ9uPg2QaO2gJv8+an+ss+Vq2rCNPpWB9Z2RgOo0/ekb3vaxQB9STWrxUaJsElyQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 07 Nov 2022 11:53:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY8pZ4QA3C9Pi6Y066NaE9A9ULoK4zWNUAgAABAIA=
- Thread-topic: [RFC PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h
> On 7 Nov 2022, at 11:49, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 07.11.2022 11:47, Luca Fancellu wrote:
>> --- a/xen/include/xen/kernel.h
>> +++ b/xen/include/xen/kernel.h
>> @@ -65,24 +65,28 @@
>> 1; \
>> })
>>
>> +/* SAF-0-safe R8.6 linker script defined symbols */
>> extern char _start[], _end[], start[];
>> #define is_kernel(p) ({ \
>> char *__p = (char *)(unsigned long)(p); \
>> (__p >= _start) && (__p < _end); \
>> })
>>
>> +/* SAF-0-safe R8.6 linker script defined symbols */
>> extern char _stext[], _etext[];
>> #define is_kernel_text(p) ({ \
>> char *__p = (char *)(unsigned long)(p); \
>> (__p >= _stext) && (__p < _etext); \
>> })
>>
>> +/* SAF-0-safe R8.6 linker script defined symbols */
>> extern const char _srodata[], _erodata[];
>> #define is_kernel_rodata(p) ({ \
>> const char *__p = (const char *)(unsigned long)(p); \
>> (__p >= _srodata) && (__p < _erodata); \
>> })
>>
>> +/* SAF-0-safe R8.6 linker script defined symbols */
>> extern char _sinittext[], _einittext[];
>> #define is_kernel_inittext(p) ({ \
>> char *__p = (char *)(unsigned long)(p); \
>
Hi Jan,
> Why the "R8.6" everywhere here? Didn't we agree that the in-code
> comments should be tool-agnostic?
The R8.6 is not tool specific, it is to give the quick hint that we are
deviating
from MISRA Rule 8.6.
>
> Jan
|
