[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v6 00/11] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Mon, 7 Nov 2022 10:30:18 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xMXT2ZVQw2wA5iL09XanV5OpL9jUtQZtDIehowkp1dk=; b=DZyPAevuzQwuHpqGi19vV/kNJwiYDXvvv8dM6G68owsJDM/JxPQsLWY1kOV1m5qqWEXNXjIK7MYHImKPtWiWMafm+djR8hooacgyhC5RCSOS9ucLesitAOmTKPCSbxo9INsgJwc0YBbmi6jHvWtcDbgCY9fA0qq4CeexkQhz9b84FxRtX0ySYMChGuXiZHIgqPwn03veTmWx37R5cYlleBW81YL0RfU+ew1f8cdcPHz7lrb4IMAL9tjZjLIrYyG2WcNIS7StYJCHedMtiEKUP1Mcsd7gcbnZJy83jDzMg/5r8PkcaqPapg7oQLF8gHUdOdahOp8/Q9ePuqDwhkWjFA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xMXT2ZVQw2wA5iL09XanV5OpL9jUtQZtDIehowkp1dk=; b=DsqU4rBQ4R9oM3hv+0Vmi7FxtD47Aqwqp2s50hhrI/jhCa+pDlIgEtrv9yjYGGfLJ3hxqlfvZX21k6O7+wLlXDUHmpkyJcP46x49GlO1EAsoavpAiUCujg7trjK+UnZrQgkVAZ4ck2B8eHjAssdiQzTfwHFrDiji/uSPZw4WnxbxJpeXiC9S7C/TMCF/YenaoKmUKQ2CSPW5/xYxEDG06wiKTK9i3LjYbRIW6oEfC6DvIUyPITE4dIW9kRgUaP3Z2X+wnNl5hNvV7puzXtCCEjyqQ4EqUAnjl80WrZTyWiuMdkfAAKROBnPVwAkQndw9sLj71ktERv93wdBB3SEGHw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=O1OV801M/6SEY9UfaJrrqAdJK7aYwgZKqBvYJB6actfRz0b5U3nT0PgVShmIAFJB8TY4x5od94LB2XcjjfI+D7QGHbh3Rjm7FkwhHlPKHB0fmwGr9MWqXLpaptwjuG7LEPQS8VKRQRrYDSc+QqgkTpYRV5OzrOztXioY1JG6VOxD+l8X1cjG6xqgdxhVa9ZrFOJKRjgkz/9WfD/rB2xPzp7iwy0/1YW9axbgI42y2VLj3iIDRKNn4tvFyL8fW2YWbb+6W710YnI0TeWFYJQdXZROeVeSmsNdXkYJD4GQe0llbzJ9qjDjcOcBJMv8ACaQFB3ucdjawmCOfvd2Ud2tpg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ucb9S2QzvMHdOa0nTJovUYf6DpbBfH+U8o+e2z6r1IbStHXg7TRf0QKlgwLwOSAA9/jz8m/wZI+ZCLxU03Ydv6m95KyDV6mukAVfKGq1vWp0gKOt2gYe20AjpKGB3N5vQTWsruFonGFVZxR5oJ//fy3tP0TbTv5i/OhB115r2hCee5pxIfF5NXbpyy+7wli4zEZxdY/dNv8Jk0vyL2PcB/+Q6n+1cRgFJQUJzF1Fwu64TgZbsEp9XCErHP/NwomewbBbFqkYlineKNl0DocNeLQQ0jpbSxvxCcBm8aQLYeEJoio6OgBbP6dzFe+cIii6oFiWZPo2swfqUReKUoYz4g==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: nd <nd@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 07 Nov 2022 10:30:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY8DVcKFNDls96akm0LlhB1cf9B64yRBkAgADyKCCAAA1MAIAAAWqg
- Thread-topic: [PATCH v6 00/11] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1
Hi Julien,
> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> Sent: 2022年11月7日 18:16
> To: Wei Chen <Wei.Chen@xxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: nd <nd@xxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>; Bertrand
> Marquis <Bertrand.Marquis@xxxxxxx>; Volodymyr Babchuk
> <Volodymyr_Babchuk@xxxxxxxx>
> Subject: Re: [PATCH v6 00/11] xen/arm: Add Armv8-R64 MPU support to Xen -
> Part#1
>
>
>
> On 07/11/2022 09:52, Wei Chen wrote:
> > Hi Julien,
>
> Hi,
>
> >
> >>> - Supports only a single Security state - Secure.
> >>> - MPU in EL1 & EL2 is configurable, MMU in EL1 is configurable.
> >>>
> >>> These patch series are implementing the Armv8-R64 MPU support
> >>> for Xen, which are based on the discussion of
> >>> "Proposal for Porting Xen to Armv8-R64 - DraftC" [1].
> >>>
> >>> We will implement the Armv8-R64 and MPU support in three stages:
> >>> 1. Boot Xen itself to idle thread, do not create any guests on it.
> >>
> >> I read this as I can build Xen and see it boots (not creating domain).
> >> However... HAS_MPU is not defined and I was expecting mm.c to be
> >> modified to cater the MPU support. So I am a bit ensure what the series
> >> is actually doing.
> >>
> >
> > These 11 patches are part#1 of stage#1, the full stage#1 has about 30
> > patches. We have some concerns if we send so many patches at once, the
> > review pressure of maintainers may be very high, so we only choose about
> > 10 to send as part of it. But this also means that we can't do a
> relatively
> > complete thing in this part#1 series.
> >
> > We want to hear some suggestions from you to make so many patches can be
> > Reviewed efficiently. Can we send the patches by stages, even the
> stage#1
> > will have about 30 patches?
>
> 30 patches in a go is no too bad. I would personally prefer that because
> at least I have better idea of the shape of the code after stage#1 and
> also possibly test it (I need to check if I have access for the ARMv8-R
> model).
>
I also prefer to this way. After we have addressed the comments in
this series, we will send the full stage#1 patches together in v2.
For Armv8-R model, you can download Armv8-R AEM FVP model from link[1].
It's license free.
[1] https://developer.arm.com/downloads/-/arm-ecosystem-models
Cheers,
Wei Chen
> Cheers,
>
> --
> Julien Grall
|
