[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-4.17 v3] xen/sched: migrate timers to correct cpus after suspend
- To: Juergen Gross <jgross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Dario Faggioli <dfaggioli@xxxxxxxx>
- Date: Fri, 4 Nov 2022 07:48:47 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9k9eFnbUR5Yd7ylvPhnSC2nYUV7wddRB8h4C+qjaxqE=; b=KyqnFn2+giKtKgP8yzKsqraOry1lbgPO7RXxx1y66afDqE9/HrzTcqYubDLRPoEHlusE1xnlvQ7rZqGfbePDrnj3ZsItxnuasCDkO0SOG7vgHE/ajsP84oHndP5wOlfObbcajIIrqJJZU/sj+rYyx+PYG7jVtp4OGSAD4mi5/69sUGn56Z8v/JvE5cHnVzy2BSMulHIbxNXBDgRi6dp7rMqiY7RCOOMipQtioe4ncbcX6RSj3S8t11+uoiOZ0Du7k8QTENZSuXo7sAaWLL23bN5Vz6QIoq9LRkbS2lsKyOmKiai7hF3mgRhrug1iVToJqQrEybTGwbJEOaRjtpShVA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kYdtXvOmN82JpE381wCcSzuwRcPW88lHeY11I8a2Wg/Nv/UGoSQvPJu1RVdE1kL8BTFpmG3iu/zqZPyjL5k4UJ/kfaXuEVMeaBMO7JN3Gq+gHnxadx3uf2PeZseRlTeguSzLS3SOn1HwRMHvd55JtXfOEd7ckj2+cQ9zs9QN5SO5BrZoyEyfhS4rKNd2hliegNfrGPykiH9GY0cEcelMRqjWGkNu5/dtYH7lWfhpqa782+jooNNskB0TtUsn7hHFegBQMRitiW/IO8nTYHoohlQyDEfcuaT2thASbuie03AIENhC3MSuwdujMojr8cPHBr/VWG4d/3+3xEpwZcQ/Mw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "Henry.Wang@xxxxxxx" <Henry.Wang@xxxxxxx>, "marmarek@xxxxxxxxxxxxxxxxxxxxxx" <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "mengxu@xxxxxxxxxxxxx" <mengxu@xxxxxxxxxxxxx>
- Delivery-date: Fri, 04 Nov 2022 07:48:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY7svfW5RCRD6BzEauaEQnxR7xn64uZiOA
- Thread-topic: [PATCH-for-4.17 v3] xen/sched: migrate timers to correct cpus after suspend
On Wed, 2022-11-02 at 16:00 +0100, Juergen Gross wrote:
> Today all timers are migrated to cpu 0 when the system is being
> suspended. They are not migrated back after resuming the system
> again.
>
> This results (at least) to visible problems with the credit
> scheduler,
> as the timer isn't handled on the cpu it was expected to occur, which
> will result in an ASSERT() triggering. Other more subtle problems,
> like
> uninterrupted elongated time slices, are probable. The least effect
> will be worse performance on cpu 0 resulting from most scheduling
> related timer interrupts happening there after suspend/resume.
>
> Add migrating the scheduling related timers of a specific cpu from
> cpu
> 0 back to its original cpu when that cpu has gone up when resuming
> the
> system.
>
> Fixes: 0763cd268789 ("xen/sched: don't disable scheduler on cpus
> during suspend")
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> Tested-by: Marek Marczykowski-Górecki
> <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
>
Acked-by: Dario Faggioli <dfaggioli@xxxxxxxx>
Regards
--
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)
Attachment:
signature.asc
Description: This is a digitally signed message part
|
