[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [[PATCH for-4.17 v1]] tools/ocaml/xenstored/store.ml: fix build error
- To: Edwin Török <edvin.torok@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 4 Nov 2022 02:35:15 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RBn5TQGgxiVIC4cO9L5KU+xwOOb0iRS6HUmpc336E3M=; b=kVNxRjQtPxjERQgUCHzjzWU6AsuAUwf1/gmKYdexexdmt1jcFfc6GNQGPAQs6kAdP+DYPAytq52dYLAdDvi/StOyBULNQEOPAH38+SE1mvtxKxiHcvdtdmMUWNrGcVddL/QCq+WxRYVVPtCDXGDac1iNPgYfHLcpnd9kj1ShP8SIXFx1OzMwQHHxA7GZ/SeumWHiaY5nN+Aw0FDBK5c0/HxXhjteezlTJ4jqH0P61+Bd4yb5iFHWXsVAq5W5gtsOwou5vOTh25ezJKM0iZekMDyiP/U+kSAAbUTnAzJgKauHYUZ/rGEnzFk1xPi58ZnRuvl6KPlPnMBDu8vgPvPcCg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RBn5TQGgxiVIC4cO9L5KU+xwOOb0iRS6HUmpc336E3M=; b=JUiC8Xj6JITdAhitlEWSnbizh1c+WLYd+eLdl95A/U70/DKf6LHg0lZxcLmYjj3Jy/2/1xQiyxOnIBod+mGUXUcez733vHiL8Oh0qATlSh8yOOtbfIkH3rko7ApVKa0t1dnUo2rE7zcWt4GQygOC2b0s0Ti2c4m8ca7+rhJyQkGZl5bK89kzjwmO4ZM1Xqy4c3ij1fqTyatpMT17RyuDWtFXXOAh1SKBS5RGz2rVxX2Os7fDtldhn5qiFk5SHTyaXGd7HhlTs1KjjmcckKGeAWaXOR6HwUYDshFoPCwBx/EvKIzAsu7Iy/T+Nttn3BGLyMAZCoKtULaojRUOq8vArw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=FjH+T3kKk28uGmsBlM0/n9N/rTvkBPaITjJMbzEoEolnYHdiqdNEmQkZaUscf0kTMRpejDNxk8Ouq5Js3SzSQWaSa78NiBDV2OpdVs6P+VZFzDTM9Vc7Od5CAPgUsp+AoPdAvpa1tMxtGsCHbDuQPSWacx0EJP5nmjp6ToBcmM8Cz7W0TPfrcF2f9J8nqID5a25OQEDawDr2Lc3CfwyWyexpsm1Waggb8pmWWcpjtDijhZu9Ycsr1SaU0TNAgqUidOyppJILVX3F7QmdjPdDt5Zjal+Pf3l3UKbS9vloV+wg0V9fG5lf1kBPs0wNA8ZH35z65XDGoDxTv2WouzRTbQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EXF/Xz2a1V2bLsMkKm1EG5bnfE/nOVABhSWlEmfZdbag85NHx6j0EJLkOKh2tiQ47H34/au2xWJvg43F9ypmquEL3HFvYisPp0IXQCT9VMWnatbvZPXpBiEx8C1FeOpJye6+apbv092pL+Uav/2BNxaZMxSZH/p9mlH6yEmWHQmZax7lq1jYOvOsy5NXFJsQl48/VOZgIkldudZsbeWuRPboTrvXjYonPa6IGHxyDMmv4uTmZ2ZmDu/7tjPjyX6ZDnhdMV2vFY6TGhrK4f2Irh4hZPuzVQvE61Coo8OePyZ9F25GOqSXvcPMzzT+h0dTIotd2WPX/KSUfLtgbpFo6A==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Fri, 04 Nov 2022 02:35:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY77Qw3hE4IDWTwEGKql4errGNq64uDKBg
- Thread-topic: [[PATCH for-4.17 v1]] tools/ocaml/xenstored/store.ml: fix build error
Hi Edwin,
> -----Original Message-----
> From: Edwin Török <edvin.torok@xxxxxxxxxx>
> Subject: [[PATCH for-4.17 v1]] tools/ocaml/xenstored/store.ml: fix build
> error
>
> Building with Dune in release mode fails with:
> ```
> File "ocaml/xenstored/store.ml", line 464, characters 13-32:
> Warning 18: this type-based record disambiguation is not principal.
> File "ocaml/xenstored/store.ml", line 1:
> Error: Some fatal warnings were triggered (1 occurrences)
> ```
>
> This is a warning to help keep the code futureproof, quoting from its
> documentation:
> > Check information path during type-checking, to make sure that all types
> are
> > derived in a principal way. When using labelled arguments and/or
> polymorphic
> > methods, this flag is required to ensure future versions of the compiler
> > will
> > be able to infer types correctly, even if internal algorithms change. All
> > programs accepted in -principal mode are also accepted in the default
> mode with
> > equivalent types, but different binary signatures, and this may slow down
> type
> > checking; yet it is a good idea to use it once before publishing source
> > code.
>
> Fixes: db471408edd46 "tools/ocaml/xenstored: Fix quota bypass on domain
> shutdown"
>
> Signed-off-by: Edwin Török <edvin.torok@xxxxxxxxxx>
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
