[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 1/2] IOMMU/VT-d: wire common device reserved memory API
- To: Henry Wang <Henry.Wang@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 2 Nov 2022 17:58:58 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IomqiuNnTUlFiZ1chlqnwiTLBJlaV13P7OUVhimZalA=; b=grkF5cqm8vyg0+rsw67Th5iWewV3void9B/aI3RlZxgrcxvzhv/dlsvSaY8zmW3lj+ZFKfrnb+CSZMVO7nf5ZkoEat2if+iQTOZtYTbSwyBvL+Zz9nxi8bP9XaqAN4OpoV5QyqI4mjVKceSu600f8N7NNkcroHQdqigPc1esmzf2/vJYCqP/gKLzYOeBhdNeIH14RBZ3GVbNgGplcVGCdox//FJ8HA+OBSvSQ0Tgz2Btr/Ajyldi6mmyf7Hs/iY+n6BINUehx8a9P6npIjZ7+hGrtvJQLXrTg/uVOvkaEsJWb7AGsLGdthQnza47Rn0mwPQFOYsQp9SMfyu3eI1KJA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mvUXTMM+P+jhIsO8H887gdxI15wWmsF82XTmxSq/Bp460v3OLPpOvMbZRyCoAmxIBE1IseGToK3LJlf1z3tgGiXzycenps3dT2397Ok51VFKxBlEph1166cKF6N8oj44a9rsTiDiJiveKqWY6PbjWtSxTi76vzQpLyclISgIey0Dv03CIgpNb3BQCRion8Er5lveXXKWnpu3U40X2nHcnL7U98LNQQ7FTllxg1A2+7y87gz1IdAQq0sAG/dDwojbswYItljjw8pOB6C04ISWhfP1g5qxqcbJDs2zNVVldhUlCW5i1kf2N7F/6ILBJIsJS2ZZGK7kdzC9c0Ho18wzTA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Kevin Tian <kevin.tian@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 02 Nov 2022 16:59:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.10.2022 10:55, Jan Beulich wrote:
> On 17.10.2022 03:20, Henry Wang wrote:
>>> -----Original Message-----
>>> From: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
>>>
>>> On Thu, Sep 29, 2022 at 03:33:12PM +0200, Marek Marczykowski-Górecki
>>> wrote:
>>>> Re-use rmrr= parameter handling code to handle common device reserved
>>>> memory.
>>>>
>>>> Move MAX_USER_RMRR_PAGES limit enforcement to apply only to
>>>> user-configured ranges, but not those from internal callers.
>>>>
>>>> Signed-off-by: Marek Marczykowski-Górecki
>>> <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
>>>> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
>>>
>>> Henry, can this be included in 4.17? The AMD counterpart went in
>>> earlier, but due to late review on Intel part, this one didn't.
>>
>> Thanks for the information. I agree this is a valid reason, but to be
>> safe I would like to hear opinions from the x86 maintainers (added
>> in CC).
>>
>> Andrew/Jan/Roger: May I have your feedback about this? Thanks!
>
> Hmm, not sure what to say here. Yes, it would be nice for things to end
> up consistent across vendors. And yes, the change here is largely
> mechanical (afaics) and to code most of which shouldn't typically be in
> use on systems anyway, and so should not pose an undue risk. But still
> it is quite a bit of code churn ...
Was this lost, did you decide against allowing this in, or were you hoping
for further responses by others?
Jan
|
