Re: [PATCH v2 15/21] drm/fb-helper: Disconnect damage worker from update logic

[Javier Martinez Canillas <javierm@xxxxxxxxxx>]

On 10/24/22 13:19, Thomas Zimmermann wrote:
> The fbdev helpers implement a damage worker that forwards fbdev
> updates to the DRM driver. The worker's update logic depends on
> the generic fbdev emulation. Separate the two via function pointer.
> 
> The generic fbdev emulation sets struct drm_fb_helper_funcs.fb_dirty,
> a new callback that hides the update logic from the damage worker.
> It's not possible to use the generic logic with other fbdev emulation,
> because it contains additional code for the shadow buffering that
> the generic emulation employs.
> 
> DRM drivers with internal fbdev emulation can set fb_dirty to their
> own implementation if they require damage handling; although no such
> drivers currently exist.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> ---

[...]

>  static void drm_fb_helper_damage_work(struct work_struct *work)
>  {
> -     struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper,
> -                                                 damage_work);
> -     struct drm_device *dev = helper->dev;
> +     struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, 
> damage_work);

This line is an unrelated code style change. But I guess it's OK.

Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat