Re: [XEN v2 02/12] xen/Arm: GICv3: Move the macros to compute the affnity level to arm64/arm32

[Julien Grall <julien@xxxxxxx>]

Hi,

Title: The macros you are moving are not GICv3 specific.

On 31/10/2022 15:13, Ayan Kumar Halder wrote:
> Refer https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm64/ \
> include/asm/cputype.h#L14 , for the macros specific for arm64.
>
> Refer https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm/include/ \
> asm/cputype.h#L54  , for the macros specific for arm32.
>
> MPIDR_LEVEL_SHIFT() differs between 64 and 32 bit. > For 64 bit :-
>
>   aff_lev3          aff_lev2 aff_lev1 aff_lev0
> |________|________|________|________|________|
> 40       32       24       16       8        0
>
> For 32 bit :-
>
>   aff_lev3 aff_lev2 aff_lev1 aff_lev0
> |________|________|________|________|
> 32       24       16       8        0
As discussed with Michal, AFF3 doesn't exist for 32-bit. So it is not 
clear to me what we are gaining by moving the macros.
Cheers,

--
Julien Grall