[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [for-4.17] Re: [XEN v1] xen/arm: vGICv3: Restore the interrupt state correctly
- To: Julien Grall <julien@xxxxxxx>, Andre Przywara <Andre.Przywara@xxxxxxx>, Ayan Kumar Halder <ayankuma@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 28 Oct 2022 08:57:37 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3VNCvhs6oGQQaRUA5pPwEFORpnG7m11d65KmpGF/gaM=; b=f7RvW00NmBNtHMgijYaZ4oIa/UCl7w04dgn9HdZOl1Lmt9u1Cm6BIRyltB6J93N1UPGHhay5NL0klqfvCZCWHnc8WBbthimRsfnoy7IeZpa+F7unEpX3RkzNFKZ5a05qSlSbsNRXa4smmyz6V0dPBuRqJT42oJiPi/Xe9pkrlbwLffnVW3wdjHg94WEzRJcjQZOfYPUAtFIVWXTk0Zxv2NM1u9g3f0iS2cM74xOyQ8o2Z0lvKIQvdyeMeIOHN5RQoJz1tbn7S22M2c/WsaLHXUUeHeWV2QqtSMhsixpukewGKeA/eR8B39RJcgLLD6/RbhNk6iouQpAhl/jFyUvmyQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3VNCvhs6oGQQaRUA5pPwEFORpnG7m11d65KmpGF/gaM=; b=I8F/eWabGOtid59yAqiWJF4T8NA4iP4qcJlogMIN+lKrkYoUTRwS9df5GImO9BbPdsWcz0lYEGsX7IFo816QmaETbB6dAfJ7WsVtp+XZtX/+HUrnYNStah9WIgNB4oIa+vYSZ4bv0Hq0ZCzCuZTTZqgzu2xgQ1piRRgTHMDeUEDPouuuabXiZeBNSNWI8b5R+dU2Qr1nc0OcfuNkpqFXDvC5hD5Sb4FKJdh6BzdWYs4xfoceC7IKihTHK9MTXl2FCBsDNNWPbdXplt9eY/1ad/P+A/GQIgYuX1JKJLHMKX3guFSa0U8ytaFezKbmGzl68y5lhcrFfOyRkaaAEegd8g==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=OLoBYMTMdgJOcsYGGrm5k6HDOLSMGgCjrJc6L5Bb/Ll0lAxXiAIZkuJb6EVCZPTJJNRMbw6gIFxrTig2dqUpIobpJGaRY4x5/QNEj5MlCDAfbDGRprIgKUyTbiKlZ+JUcHXJ4B/wC51OghDl3Ixr9D2oMHYdU2acTDGm2zBJGszWwrI/JH72UEl0zs0v2yRKNJauc5p8HqHn5DqEqP8dtyY1sWQfwUpTHSuUHcXxTm5JFldSlHFvKRRmaNrzR8dT/eaENUm9r0lG3ZPIfmW/Zh4Ue7Xc97mhNDDFk82FAa0Kz7Gyalt1CW41+sTS5NeoLA/JUWFnNz1mIGU0XbxPhg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UQEt4SCXUZWU8rzeABhBaAdd6VxHDON2quuyBCJDzCRbC1SH/1xw0gwOLH1HdfHmvRCGCkHHzDnOcZghsrr/PvjoRiizw3sUzhgCg73Fjp33DmmgNETY7Df2M0cjj/7oIMhVF3F1WgbvPqI+nxZ8E7Xyd6ihonAtsZrpJsnP5yTHrK1aPicTuC/Kj/Gk+w01vbZFIhMc0zgnudJUlv6EIu8L3UlFYG76DGRXKFNZuC9miGJ6ZlWlbh6n7fhGDNvEp8T3N4OxLn5Xa8SphufZaJaxmbIcrVxpyV4nBmMuwO2j/CYmdcWwHe65QrpA3IrcFtxep4mGQFB0N3U4XqXH7w==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "stefanos@xxxxxxxxxx" <stefanos@xxxxxxxxxx>, "Volodymyr_Babchuk@xxxxxxxx" <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Delivery-date: Fri, 28 Oct 2022 08:58:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY6jes783wY66tZUuv7V7GxLd9Pa4it9YAgADJ0oCAAAA2oA==
- Thread-topic: [for-4.17] Re: [XEN v1] xen/arm: vGICv3: Restore the interrupt state correctly
Hi Julien,
> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> Sent: Friday, October 28, 2022 4:56 PM
> To: Andre Przywara <Andre.Przywara@xxxxxxx>; Ayan Kumar Halder
> <ayankuma@xxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; sstabellini@xxxxxxxxxx;
> stefanos@xxxxxxxxxx; Volodymyr_Babchuk@xxxxxxxx; Bertrand Marquis
> <Bertrand.Marquis@xxxxxxx>; Henry Wang <Henry.Wang@xxxxxxx>
> Subject: [for-4.17] Re: [XEN v1] xen/arm: vGICv3: Restore the interrupt state
> correctly
>
> Hi,
>
> On 27/10/2022 21:53, Andre Przywara wrote:
> > On Thu, 27 Oct 2022 20:09:13 +0100
> > Ayan Kumar Halder <ayankuma@xxxxxxx> wrote:
> >
> > Hi,
> >
> >> As "spin_lock_irqsave(&v->arch.vgic.lock, flags)" saves the current
> interrupt
> >> state in "flags", "spin_unlock_irqrestore(&v->arch.vgic.lock, flags)"
> >> should
> be
> >> used to restore the saved interrupt state.
> >>
> >> Fixes: fe7fa1332dabd9ce4 ("ARM: vGICv3: handle virtual LPI pending and
> property tables")
> >> Signed-off-by: Ayan Kumar Halder <ayankuma@xxxxxxx>
> >
> > Thanks for fixing this!
> >
> > Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx>
>
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
>
> Henry, this is fixing a bug in the ITS. The feature is at the moment
> experiement and the code is not used by other subystem, so technically
> not necessary for 4.17. But if you still accept any bug fix (I know we
> are close to the release), then I would like to request to include. It
> should be risk free.
Yeah, of course.
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
>
> Cheers,
>
> Cheers,
>
> --
> Julien Grall
|
