Re: [PATCH 06/10] x86/mem-sharing: copy GADDR based shared guest areas

[Tamas K Lengyel <tamas@xxxxxxxxxxxxx>]

> @@ -1987,7 +2056,10 @@ int mem_sharing_fork_reset(struct domain
>
>   state:
>      if ( reset_state )
> +    {
>          rc = copy_settings(d, pd);

> +        /* TBD: What to do here with -ERESTART? */

Generally speaking the fork reset operation does not support "restarting". While in the memory op path the error can be propagated back to the toolstack and have it re-issue it, on the monitor reply path that's not possible. But the important question is where does the -ERESTART come from?  What I think would happen here though is that -ERESTART may happen during the initial fork op and that can fail, but if it succeeded, then during reset it can't happen since everything would be already allocated and mapped, the only thing during reset that would be done is the page copying.

Tamas