[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values


  • To: Michal Orzel <michal.orzel@xxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Mon, 24 Oct 2022 12:18:45 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a/Sjc6jRJdXwkBkdhTMQhKo8EjZykD/bE39uMjhYWMw=; b=E45Y+tLl7ugXNUPmhufNmylMObqM7tScVUWPahyIKw8hTP12jWdTHUvLPkj50cQe2CE8ZdlkWmw0vTd0kV0x1UbGnzvc53m+7dWs4C4Tkc5o2uhtAt3BEtRKruDllbglW1VtmktdLAM1FKy9lxkuurHxJl0FNOKzwr9xmBFcEeRQ/jjE58nC2fbYBMlk3spnyAQokDcMybEpbzg0VqQYfTHTpdpmw/O01BPdIlV8Kn62m7T6fHL/yMvtc+rp/7TI6yvL8g9UjYi+1Wm3S2Bk29380kRIhg5Ru/K8//UGLA6Zstuyc0eFdJWEP7flFDaO1Q746yvLqDjkWH2eSa8KWQ==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a/Sjc6jRJdXwkBkdhTMQhKo8EjZykD/bE39uMjhYWMw=; b=HLNk+WA9TyLkqPAyQ6CzXW9VYpPX2mUeM1UZzMcXstNGCtcP5658Qsc+jpPBLPUviN4M64AeCgcphq/aV+bjaF77DSFkO2WR73PkRiyNRTg7bzRcQcCupb65XIJ7xsR+BjYvZgRTf4psCnN8Gv5qi2+p0OKh3Zm9Bv6KlVSkpBzH25XYjC/IKYeo2hGQAl6Gvr7P14TKVH8ZS9U79eAfd2Eoe1ZeC3vdKtPQXeHa4ssgvmr2I+hjDtFZBukEtg0cZyq4Rb6wGiHt1FbiVUThv2nurveiXPcMl32QhbS3gR/SsjxjQx8AMOqtO1Z95mJhYrzDuCxg6QgzxOFk0ckSzA==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NbgB3KFhAHU4LMWr+knGtuHhErRgbPb1yqFZoby2qwOd5q1+g8ltdpAKQiKNa2aBVVTooVjgVn1zrVqvWC7MTSdmrxy397R1MrMx5DB/LqHs3OOx2O0ON9hwKGiZAoMLOFyc1PmKRNwk7qAsC/D2tFa64DdN1vQiV98ry2cOhGrWexcgQwo1qN5P7vMX+oKsEMj8dGqSgRwc1XNJgd9NwLvN7kgKGVSmHr8VcwOStlHTlQxCN+uRe1uK+0Om516h4m/jbXinf6iNVaWoc9acwiJ0QCqE5WJlqKTHyfc3hJO9D0KT/QMMc43SHvIzKpN6VR0S6COPWUykAU5v32iNkA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OH4kBTp0Xv4jAbnhaP+8eVdkqZq3gzfKtc7RVA7iqacYNrjZMtaXz9KMwJjKHKFOmWgOKoeIiEa4IlY3Zsv5Ai9h4kgjNxc6t7CncyQcMqMK6+8s0vPDWfiWibpQIzSqjhQ+7Few8FKbXE0NdaW48Jim+R2l11hqQOWWNXwGqcQZdRlu/uKbQdo2GN5DCKmINHf2moj8R8RyyyJLfD9GUs47SV2TSDfxzZfPN0li5JAlSwrF/tnLfZKmDPgc5e/CSPRWfSMwZ9yQf7Ioy8FNKZHdl3QdsqHz2FkaKKUpeLAoRGTQ3Y67r7qw6qV9IQFOjBTsn9VJQFAkcQ1/ciGZRg==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Mon, 24 Oct 2022 12:19:10 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHY55BMcvguN056m0ylAZ3lyVdtTa4ddmQA
  • Thread-topic: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values


> On 24 Oct 2022, at 11:05, Michal Orzel <michal.orzel@xxxxxxx> wrote:
> 
> Make use of the macros defined in asm/pl011-uart.h instead of hardcoding
> the values. Also, take the opportunity to fix the file extension in a
> top-level comment.
> 
> No functional change intended.
> 
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---

Hi Michal,

Seems good to me!

Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.