[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.17?] test/vpci: enable by default
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 24 Oct 2022 11:15:13 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K5+1lkwkbKm2lGolHyPNAs6iJWgMx/TbQAUcDeuqN1A=; b=guUKlhrB0IGkotBWZgl+a3YY+bwsiP++b5d9U/j6EFvuOZtxEStdHEgYQx9wYR3mzm7GlDxwxQtTpTysOh7jcoiWUxSFQ8GSKRxVD4GI0tB/bPqJs0KGOE6N5O6mzyTVD6lE77XjlY0RL9EJ+ZpoSa1HFGG+MsAhOIeD8jJR3XnL9eBqJnYuosBktCce/YWcrb/wtY3dAZhNB3b8bNNcb5fyZE3cnZakACFWHYmiZM4HzJ9RNA8BPmLtEO3QxUzXFxLYfAIZ59xf9ydYc5BdLlw/WTr8WlF5mrYbHb/VIh7ZgOx41kmF9SzAyGPTbFET9SzuB7APdLfQ0CermSn9gQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ArVaPxWpqPb9SFArRn6rpsgenIDAwx6ATNSAcqtHjMI56GaKwbgwYnysQz8o3aqhaXwHji6uClbwtGVe/rQ2ap1UEWG4/lP2Kf+QcNfOX7GUbnAg05HqeOZnsOp2OnYrPBCuKsohYp66lC2ZP6xAbSf6yO6u8zHMPGHccJewPfb4kR76WSFbwklDEaoGBSDKX675u5sMDrHJAQY7zJxfLEX17OP/oGb5WIxJ2IB8njaGVMCoTgSL62CbUe49vP8HNbGUDEEyHwJAQh66jtzsUkxuHBwpj85dAo3dicSwDrfZHG5NttPH2FtxsXIZzaGArC0ISPWkzTTLXXk5gjX0uw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Henry.Wang@xxxxxxx" <Henry.Wang@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Mon, 24 Oct 2022 09:15:52 +0000
- Ironport-data: A9a23:4hCEZKNovd7QtevvrR2/lsFynXyQoLVcMsEvi/4bfWQNrUpxgjAPz 2MbW26Db/aCa2H1ct50btvi8k4BuZaBnYBgQAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0 T/Ii5S31GSNhnglbwr414rZ8Ek15ayo42tC1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eZ6sE8fR6Wnt15 ds2MDRXbkDZ3MGz6efuIgVsrpxLwMjDGqo64ykl5xeGSPEsTNbEXrnA4sJe0HEonMdSEP3CZ s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsH8BTM/fdfD2v7lWSd1JD3N9XYYJqSTNh9lUeEv GPWuW/+B3n2MfTPk2bbqirx14cjmwvYYIwZHuGo6sdLw2ezwHA2NTw8aHyS9KzRZkmWHog3x 1Yv0jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcL8wwufHHlCcTdHZ/QvrspwTjsvv neWm/v5CDopt6eaIU9x7Z+RpDK2fCITcmkLYHZcSRNfuoG+5oYukhjIU9BvVravicH4Ei3xx DbMqzUig7IUjogA0KDTEU37vg9Ab6PhFmYdjjg7lEr7hu+lTOZJv7CV1GU=
- Ironport-hdrordr: A9a23:c9eIwK+Uz/SJnxCZisVuk+FDdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdhrNhRotKPTOWwVdASbsP0WKM+V3d8kHFh41gPO JbAtJD4b7LfCdHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaF52IhD0JbjpzfHcGJjWvUvECZe ehD4d81kydUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInty6IZn1V KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXkIidDqzGxvvM jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6W9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI pWwmOwrfNsfF/9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmc0a+d FVfY/hDcttABKnhyizhBgu/DXsZAV4Iv6+eDlMhiTPuAIm30yQzCMjtb4idzk7hdAAoqJ/lp T525RT5c9zp/AtHNNA7cc6ML+K4z/2MGXxGVPXB2jbP4c6HF+Ig6LLwdwOlZKXkdozvdAPpK g=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Oct 21, 2022 at 07:01:01PM +0000, Andrew Cooper wrote:
> On 20/10/2022 11:27, Roger Pau Monne wrote:
> > CONFIG_HAS_PCI is not defined for the tools build, and as a result the
> > vpci harness would never get build. Fix this by building it
> > unconditionally, there's nothing arch specific in it.
> >
> > Reported-by: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > ---
> > While not strictly a bugfix, I think it's worth adding this change to the
> > release in order to always build the vpci test hardness and prevent it
> > from bitrotting.
> > ---
> > tools/tests/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/tests/Makefile b/tools/tests/Makefile
> > index 33e32730c4..d99146d56a 100644
> > --- a/tools/tests/Makefile
> > +++ b/tools/tests/Makefile
> > @@ -10,7 +10,7 @@ SUBDIRS-$(CONFIG_X86) += x86_emulator
> > endif
> > SUBDIRS-y += xenstore
> > SUBDIRS-y += depriv
> > -SUBDIRS-$(CONFIG_HAS_PCI) += vpci
> > +SUBDIRS-y += vpci
>
> I'm afraid this is only half the fix. The other half is:
>
> diff --git a/tools/tests/vpci/Makefile b/tools/tests/vpci/Makefile
> index 5075bc2be28c..336904958f6a 100644
> --- a/tools/tests/vpci/Makefile
> +++ b/tools/tests/vpci/Makefile
> @@ -22,6 +22,8 @@ distclean: clean
>
> .PHONY: install
> install:
> + $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
> + $(INSTALL_PROG) $(TARGET) $(DESTDIR)$(LIBEXEC_BIN)
>
> vpci.c: $(XEN_ROOT)/xen/drivers/vpci/vpci.c
> # Remove includes and add the test harness header
>
> so it can actually get deployed somewhere useful.
For now I just wanted to get it to be built by default. It wasn't
clear to me we want this installed, as it's a standalone unit test
that could be executed as part of the build phase (doesn't require
interaction with any hypercalls).
It's also currently built using HOSTCC, so installing on the target
would be wrong for cross-builds.
Thanks, Roger.
|
