[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
- To: Henry Wang <Henry.Wang@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 21 Oct 2022 14:56:34 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N+AJTeUqYNtxnch9ejq92GsYm13vJfj9SOXeRKb1HDc=; b=a+13BAqc6dCzbI0vlAUAdIE/AyzFL3Wl9bolHs2eod/2pSREkmuW6/KbRJ+Xdifookk3ff/iC4BV4IdN8wJ86kHrGtouMbuM+jlSLSlwdNrFD1zOXA+BuThQkSo6pmuMSIuFZ4PfPdrm9SmP+aBkq8QNhlaS2uOFfGknBQiJraYXijrSNB0M27JKr4DnhL45YsQr54OzPaSoukvXPpIATW9PFdOgRPyXYYSoejGyJ2Ghrr1RJa4yPcSIMknEIWoNJnz/g0eHAijuCOydCW4BjHe3AVkYgITniTanAzHNEt43dlDPXbrdOV+slwx6A3gUkKZSeGBeEbmpKVb9eVQROQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N+AJTeUqYNtxnch9ejq92GsYm13vJfj9SOXeRKb1HDc=; b=SNz722bPrgctMZ2J/Dn4nFjJ8cnmxbZ7a/EB2aDmEElzCx8zu1DHgQrgT7I8UCra/epo1Pv6+UlNz+LFGa+/c7szDy81y/H2MNdtrxaijDdITysN3RWL0sEBS89YXSREcqs1amehKyWaQ+owsGdADxtTgKcS4DhZOq0F5duh7p239nLyJCfrMTzP5jS3uS6M51NK91mwIulM/812fMxrCN0zQzn2a5fuMw+S9l6orRc9d7RnH4OtOLjxwt+0A12xcTslUsF2sqh1lYlFb3kqcNVWYFMC6A1V9nslWiDeM17pwxbRhucF4EpxYmcFC7To5l5UDutnylgHbZ9LDfDFzg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=YGtSxNE5myEVmeZVr4nwGmHWhkPAtZyFt2cU7ljqFCFAfMna8Wa1+yp/DAgveqHlZ000Y7e34E8y/U2CJEEDksX7gp9872FpW6tu/KNsFUe1YsKe3/rYG347Sjo/NGcDZHev1QnWBJa4/ZEVHSem6lHDMbZRZ63tOMuj1+xHLmZ/sHOWDO8rZZpR4MdLz79NJLmNjq5oiR2K6oGcfolzJk1z9816vKLBgFwV/+OHpPYCzTc/Bv82pHc9NMQ1S4/e95KCiH6K13y1Q/kdweJR6q1a0zSb5Khv7ZuD8+U3w9ju94KSXsg00W8uv1CwpvSJZLXabOGCUgYSrgA5OOFWoQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lzfO3JzAtCLuGcxXSEDpC0OwPgrpUzHRauBHLsXaJkSipYl4S9kimjIxPdKb1h73WB5UtYkxr8IJr9rwmQ4G+djmtYlvYRpVQWipqbF9NPiOyr49Gh503yw1cbxK7t1g6dSoA82NM6AXILV0OLTAMjGxuGVEcH75f/bx/N/sx1EMIzSwC37AojccN+7t0S/p5eD+bWyRB9iBzpFXssIrDGx+ianmPutmXPOnKhdsMo4Wl+27J5ADDSLfVNZaQFLdeZdu5/LSZlv0kXQzPnx0p6Sqci98BTL4QKPgKh0KorSyrxavfD6tYn54IIyGNwL6Pb0C+n+BPnsHf4VZ5eDVEg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Oleksandr <olekstysh@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>
- Delivery-date: Fri, 21 Oct 2022 14:56:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYmuuiv6EaG5L7CkOUEJgfIhzZ362FNeCAgABJ9YCAAAJFgICT+/QAgAACL4CAAASKgA==
- Thread-topic: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
Hi,
> On 21 Oct 2022, at 15:40, Henry Wang <Henry.Wang@xxxxxxx> wrote:
>
> (+ Arm maintainers)
>
> Hi Oleksandr,
>
>> -----Original Message-----
>> From: Oleksandr <olekstysh@xxxxxxxxx>
>> Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
>> Hello all.
>> On 19.07.22 13:40, Jan Beulich wrote:
>>> On 19.07.2022 12:32, Volodymyr Babchuk wrote:
>>>> Jan Beulich <jbeulich@xxxxxxxx> writes:
>>>>
>>>>> On 18.07.2022 23:15, Volodymyr Babchuk wrote:
>>>>>> Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to
>>>>>> iounmap(), but not added corresponding include.
>>>>>>
>>>>>> Fixes: b4f211606011 ("vpci/msix: fix PBA accesses")
>>>>> I don't think there's any active issue with the "missing" include:
>>>>> That's only a problem once Arm has vPCI code enabled? In which
>>>>> case I don't think a Fixes: tag is warranted.
>>>> Fair enough. May I ask committer to drop this tag?
>>> I had taken respective note already, in case I end up committing this.
>>> But this is the last patch of the series, so I can only guess whether
>>> it might be okay to go in ahead of the other three patches.
>>>
>>> Jan
>>
>>
>> I am wondering, where this patch could be 4.17 material?
>>
>> The patch series seem to get stuck, but the current patch just adds a
>> missing include to fix a build on Arm, so it is completely independent.
>> I agree, there is no issue with the current code base as vPCI is
>> disabled on Arm, so nothing to fix right now. But as PCI
>> passthrough/vPCI on Arm is in the development stage, the developers
>> enable that support in their builds. I think the risk is rather low than
>> high.
>
> It seems reasonable to me, but I am curious about what Arm maintainers
> and PCI maintainers think. From the history discussion in this thread I
> think it is pretty safe to include this in 4.17. Thanks for the ping.
I think this can safely go in for 4.17.
Cheers
Bertrand
>
> Kind regards,
> Henry
>
>
>>
>>
>>
>> --
>> Regards,
>>
>> Oleksandr Tyshchenko
|
