Re: [PATCH v2] xen/arm: mark handle_linux_pci_domain() __init

[Julien Grall <julien@xxxxxxx>]

On 20/10/2022 19:56, Julien Grall wrote:
> On 20/10/2022 19:53, Stewart Hildebrand wrote:
> > On 10/20/22 14:19, Julien Grall wrote:
> > > Hi Stewart,
> > Hi Julien,
> >
> > > I nearly missed this one because it was threaded under v1. In the
> > > future, would you be able to send new version in a separate thread? This
> > > makes easier to track it.
> > I will keep this in mind for next time.
> >
> > > On 14/10/2022 21:09, Stewart Hildebrand wrote:
> > > > All functions in domain_build.c should be marked __init. This was
> > > > spotted when building the hypervisor with -Og.
> > > >
> > > > Fixes: 1050a7b91c xen/arm: add pci-domain for disabled devices
> > I missed parenthesis and quotes around the referenced commit. To keep 
> > it in the same format as other Fixes: tags, can you please add during 
> > commit (pending release ack)?
> Will do.
The commit ID was also too short. Xen (and Linux) moved to 12 characters 
because 10 is not enough anymore to uniquely distinguish a commit.
You can ask git to change its default value by adding the following 
lines in either the global config or per-repo one:
[core]
        abbrev = 12

It is now committed.

Cheers,

--
Julien Grall