[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH-for-4.17] xen/sched: fix restore_vcpu_affinity() by removing it
- To: Juergen Gross <jgross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 21 Oct 2022 09:20:44 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QRo9cwduNcbGQfH3paCPshEx6Ju0ep5rgG2LRB/zWkw=; b=I0IpfCdNf2bNF4gjy90ONzLHra8TjnBwThAFTlXBUlIOcWDBaGz2mBSFPhbRze3Xc/qA7WtTwsVM+LCwc6kSX8hrSEAwz4CoCwuE08PUn59ZFbAlLwp+sptMnMdIIErOrOFeiYIPZS+iF+w87ox5pV+Y5Ci3ekdD9hGBokaDmgOirsd17exohg5xzjAxZBYRu4ELlyZdmSlnlxIe2QEV8651daRmlcY2eqAu0IdD5J+ejNV7j2ut/0ifBmV09eqfQWHFwsXApKEmnc3yVzvL1vaRCoRN3PieF/Jca3c4ciiuCLGA+i2eHW39WW3j7bDzd7/Jd2aP56gUwtN4M3yBWg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QRo9cwduNcbGQfH3paCPshEx6Ju0ep5rgG2LRB/zWkw=; b=StR10vsICyyFPNrjqSmmHV6T14aS34Q9CssU0+wpqdsj0R+7hrLUmnoP1NBz5x/eodXgZv1SzUCo5ye7X8uB+ibDimmo9c0fMPfABjwJmyp23668qLL3vE0GQL3Y8VSY+LlebXuCsPUJI0yFVe7rexDh0KNFSsf7c6CnIkVVWPCX5Qwg67KxjIxRRYe0ZNiiq0Rk7DGY1lN8vIQ9t4aj16td3IRTh4lrlbu4ZeiHtqVSMCG/hKIuLrsSqYgLj/drWfK0il3Lozj+NMqhsfZ5ezXmvG69iawS/38MYOlAlNabUwAOycZkJ8vA1zcpLMr5LTsjbIkU+PXiJI3/BvP6ag==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ZvAgAvaUAOwpVpWI8hUaGyZkdfepUgRbE2c8mPiO6O8wT3nXggoizWtgODQwO2nojJvkTTfwBv517X3h9mKE5HV0aRVTgrzHdll5SEXiLNfhxCugqhrPqBpqrbvJyt+S6XRACcOSw6tyAubflqv4GPyHvHTNimwg7Rgp++3Z2nY5mhQTyv48pQW4jYeDW3Q5I5TdwB+l/+GjDt/WbhTgvOgFBeDi9wRj1SR1Sjnqqlt9Hz8BnR8+2usNYvMF/FBc6SPYUlZ6SrjeSeH9DrzWoLPFcDOwFVmoOBLdyPCfzljz9WoD/4vmK4wL43bv4i+odAFBJgbeJLmT1/BPhlVfnw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gR7TBROpEb1ItZ4TWgD2carUnzcDe/eg91Vv2pJQQKxmUAfeDhqalwpFo5u8pbWfVfRAQpA1QJ7I1gHKIu/pF0ozocgEt+nQoH4cy1+09Hv7apfn85dReOFkVd5TrK4qysqSjF/JIjP+tSWJmBuQH9kogASgLyqxhtdItygUECVBtPQrCNkjQ1cxeTtpj38/KDsJYSS2fMYtQcJ43GGAEvowQyhzizLkbvXvSkUgnSKdhpY/Arx6f+06kWryJl3iDwBlccLZGN3jA/gAfyGKQI/SzXwbkrYUB4qAStN5ljuQLahkz8fsGfChePnTqYARMCv7H0s8mjHYGWznRYNX0w==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 21 Oct 2022 09:21:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY5RqBnzBJia4a50i9lxNo6dG1Ha4YknlQ
- Thread-topic: [PATCH-for-4.17] xen/sched: fix restore_vcpu_affinity() by removing it
Hi Juergen,
> -----Original Message-----
> From: Juergen Gross <jgross@xxxxxxxx>
> Subject: [PATCH-for-4.17] xen/sched: fix restore_vcpu_affinity() by removing
> it
>
> When the system is coming up after having been suspended,
> restore_vcpu_affinity() is called for each domain in order to adjust
> the vcpu's affinity settings in case a cpu didn't come to live again.
>
> The way restore_vcpu_affinity() is doing that is wrong, because the
> specific scheduler isn't being informed about a possible migration of
> the vcpu to another cpu. Additionally the migration is often even
> happening if all cpus are running again, as it is done without check
> whether it is really needed.
>
> As cpupool management is already calling cpu_disable_scheduler() for
> cpus not having come up again, and cpu_disable_scheduler() is taking
> care of eventually needed vcpu migration in the proper way, there is
> simply no need for restore_vcpu_affinity().
>
> So just remove restore_vcpu_affinity() completely.
>
> Fixes: 8a5d50dd0b04 ("xen: sched: simplify ACPI S3 resume path.")
> Reported-by: Marek Marczykowski-Górecki
> <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
