Re: [PATCH v13 00/17] qapi: net: add unix socket type support to netdev backend

[Laurent Vivier <lvivier@xxxxxxxxxx>]

On 10/21/22 08:50, Jason Wang wrote:
> On Fri, Oct 21, 2022 at 2:46 PM Markus Armbruster <armbru@xxxxxxxxxx> wrote:
> > Jason Wang <jasowang@xxxxxxxxxx> writes:
> >
> > > I've queued this version and will send pull requests shortly.
> > >
> > > Any future comment we can do patches on top.
> > Please give Laurent and me a few hours to try to improve PATCH 17's
> > commit message.  Which you could then integrate without a respin.
I'm going to send a new version, only patches 15 and 17 change.
I moved some changes from PATCH 17 to 15 as asked by Markus,
I have updated the commit message for patch 17:

    net: stream: add QAPI events to report connection state

    The netdev reports NETDEV_STREAM_CONNECTED event when the backend
    is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnected.

    The NETDEV_STREAM_CONNECTED event includes the destination address.

    This allows a system manager like libvirt to detect when the server
    fails.

    For instance with passt:

    { 'execute': 'qmp_capabilities' }
    { "return": { } }
    { "timestamp": { "seconds": 1666341395, "microseconds": 505347 },
        "event": "NETDEV_STREAM_CONNECTED",
        "data": { "netdev-id": "netdev0",
            "addr": { "path": "/tmp/passt_1.socket", "type": "unix" } } }

    [killing passt here]

    { "timestamp": { "seconds": 1666341430, "microseconds": 968694 },
        "event": "NETDEV_STREAM_DISCONNECTED",
        "data": { "netdev-id": "netdev0" } }

Thanks,
Laurent