[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] tools/xendomains: Restrict domid pattern in LIST_GREP
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Thu, 20 Oct 2022 15:09:11 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/P0q27pz/FUCbiWfSIqDDlKVjjKuwMR5EdZlip6iRNg=; b=ZqWmuSbG6l7MLWlU7Q3yq6CimxiHbXyS3I7yn55mPZQ5FGFcLwP19KTyCPSOlUnQywzgxkSsoNMUYf2jpv5iK56VAV2dlZfqvhNqQWlRl4IdGlyM1Q5usQ8tzN0h6NTe74Si/p/lE3TXgYaAJGjCettdlWfqr6lt0scWPCzeHCrXjF6T5lojCwvypCLNFLGK4DYW34be/rpzzMThUs8UZ3lh3B8NrVnMVgbZGbWM5Ei45pxxd9sjW7vDjzi1u2jvzc7jp+iHwBMnL5Z6X3JGO4aLtFfsrD0JoUNcM9axOZzEy0r4U1spvmzBXQ0gADXW4t3FZ9bocH1FCXKs3oBQ8A==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/P0q27pz/FUCbiWfSIqDDlKVjjKuwMR5EdZlip6iRNg=; b=g8v2kjLbjnqBUDTdWf2MO02lsOVb8HlyUPSvEcSo8HYdTXLd7tL6zwdpBvZ27Lyq2C2lSGw9zbmFMcpytPyO9ROr21CSS9lTsho5hzBjgWW4UctNh3q4/4lcW9Tk+gdGDxUWXU24smA9KArcFlI1p1WFYivMM6+MuzeF4Z+h1Jugj8uQ8MCk41q4St/bUA43hy5vkAfdwBXjYRZVg2TiYGFgBoLYThKPRJTblNTfx558wL4PUNXn2GoYLatMPU9xFmjieLLWlUNJjuJFpsAEV9OdM+KQ5h6UGAMbVwQRiPiQLnZVYf3/o+k5N4QaVdXO1bwbAbIvnfOby/61u6lgow==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Kw9htgoVFgnX2rd9KWH0lloCwlvF45bHh5xC9nP1z8YJHoZyhUcShTZc3MlkCPqzY4k9+Jc/+A6G7tIgEqTHyvBBfquBALOZ5f5GFWkku+DCbCS7a6NFkcmDN7CSCu5bNgGXU22wPPL9qYdAxEjsX0f5OGgW3sux1/118Jf63jk8NJq5cquuM3a38RvKeTS3qleGKdHCmjgV5Fq2xOcyWHaP9czCh0pPgfH2zyJKEzLjhFcjFPl95B3KXvjyXsedAGhmNYqSneyBz9t71GwNjBIhvoMTqsnQnSj9XoVAxKEpC/f0Zq8uFeUUnFuv/5yj5FrwJ8yipSkPhDiwq/iO0g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bfF24NVO24XLJaLsuBjgG/vvXDYdonirzSBNlMnBY3Yu7QzRfpb04kpg7tih/DbwiKlCeToQWhsKiFOQsNveSYHg5xjO361k4K7X2tdas5hrOER+GDTQNrNbq8Ncfw7LVRPI2fCXm3VandcQrQI4VbZL79HZXOPFwhA7nZn/hYR+3EDKMpaJUcqcuSUtKqLpsfjoA7T+3U3BOWOELE0hsTgCsHyCUkZyOBY9wszlH8O8kxiGCVxgvMTTyFAhVZ0HKiSIucfFudsNorJOAyXrs0O1qpiL9V/WVczn6lerowjrw/WMdgvCj58YgJGbmsAwN+TXTAjs4L/U3gWfgN1vTQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Peter Hoyes <Peter.Hoyes@xxxxxxx>, Xen developer discussion <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Diego Sueiro <Diego.Sueiro@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 20 Oct 2022 15:09:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY1zZYWIYAed9yGUubROrgwcpFPK4T5LaAgAOX3QCAAACvYA==
- Thread-topic: [PATCH] tools/xendomains: Restrict domid pattern in LIST_GREP
Hi,
> -----Original Message-----
> From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> Subject: Re: [PATCH] tools/xendomains: Restrict domid pattern in LIST_GREP
>
> On Tue, Oct 18, 2022 at 08:13:57AM +0000, Bertrand Marquis wrote:
> > Hi,
> >
> > Gentil ping on this one as it might be a suitable one for 4.17
>
> Yeah, that might be a good bug fix to have.
Agreed.
>
> > > On 3 Oct 2022, at 15:42, Peter Hoyes <Peter.Hoyes@xxxxxxx> wrote:
> > > From: Peter Hoyes <Peter.Hoyes@xxxxxxx>
> > >
> > > The xendomains script uses the output of `xl list -l` to collect the
> > > id and name of each domain, which is used in the shutdown logic,
> amongst
> > > other purposes.
> > >
> > > The linked commit added a "domid" field to libxl_domain_create_info.
> > > This causes the output of `xl list -l` to contain two "domid"s per
> > > domain, which may not be equal. This in turn causes `xendomains stop`
> to
> > > issue two shutdown commands per domain, one of which is to a
> duplicate
> > > and/or invalid domid.
> > >
> > > To work around this, make the LIST_GREP pattern more restrictive for
> > > domid, so it only detects the domid at the top level and not the domid
> > > inside c_info.
> > >
> > > Fixes: 4a3a25678d92 ("libxl: allow creation of domains with a specified
> > > or random domid")
> > > Signed-off-by: Peter Hoyes <Peter.Hoyes@xxxxxxx>
>
> Parsing json with bash, grep and sed, what could go wrong :-). Anyway,
> patch looks fine:
>
> Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
>
> Thanks,
>
> --
> Anthony PERARD
|
