[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH for-4.17] tools/oxenstored: Fix Oxenstored Live Update
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Thu, 20 Oct 2022 12:45:28 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VG8yU+u748vLik9EGxDwwv7tyZtNd19IyC3/160ygFw=; b=aAA5hc7/Tl/1GtZjNo0IKwzw1/e9vGJ5mf+vJOCh2GqNbeiEumataKLnbwawjA+XJpM32/gIVLkv12NBNbD76s/kKUBJN/uVu25tczZBMViCAvS6lnUZiL5cCCUUCSRdCGO55tPvjsH4++PtDgksaQslGorkbouVNjxNhh52oAbM/AqDGm2dPu2xRPAAnFUvh8HKDiogY/+fshlV/VeSqNEIgzO9laDyuXkQcDpIEcACOAcjlA+fkOGsbQBjWvbIVh+zOBCoIOIIUW2fZTpj0IXjKsTCa3rcZv9dKtV8wKJs+FUL7vZZ1peALyWyK8dtv5zfxOXCDtoqCLt+jWEybQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VG8yU+u748vLik9EGxDwwv7tyZtNd19IyC3/160ygFw=; b=MhWtGWTfVRCcFuGJxG6/7HXZTq1XJYmgmrroCWYAXpdLxaA1r8fELRAPG7ew+P5Lr0e3eaCzCzT4eBhMf/jtj5M69z9YynA3OnRLmbvrGIG63u6HKd8MQrqj9h6zpqTY2FEUaE5EE9c4CDwUKH/Yfo1b1McY1DXQvU+uto17iPUBpuDkWaiu8mRzwWH941i3Nxsc8UYknrcDBmVNdblaAKJu9EaZrb2xQX/2hLOtcKd2ZgcrH5ieeCOB+IEU/viChWuA86UrdGzUwGFFPcmRjQ+NVr5+7walGohqGxhAR8Dy7lQiUSrqoQkGLuiP7153kZaQgNVDWd0uI1DcvsH1iw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RpKTVGyyWt3Umr7DeAHm0y8oIUrzFuv+zPFLHpKthDZOLoTJx4IyO98zqSoIKfVF181s4EaK8N02OYmpZxZ28TK4GyqUqie7elzY132Qsga1IZnSrYLZgpEVA466z7aXgu14qlFEU7Em0T5AFjs8R4sVFBkLkp2+9YRlCMUIz7tEspK6Lxx4re+aIp9VOaYfDVxGcN19isl/bKg8AvLL4NO/rTTzU0RivGLRX30gO0/78iMmldjMKioBjbMEooZch++6hnh9Mz+YH6zhYY587wHmZr7/jJx++K+168GLVpAnoOpqCVDJ08lK81qWJPXJVxazHkpXgmEm/ClCw4St5A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PsqqcgfFBZ1x7VuUG/0TcQxQtDYh8ld9fGLZP2aOWmGhQQmALKyhA+nW9wyNm+jqh9r2O/HGHlvC3nPtMxfY1sBqN/QbDyMNSKmxN8nzIWy+El7VSSde8p4oVu0QiDT+URUeAQBp4S0MUQdVDbs8MyijOGl6NDM2pVflC/P0sM5aB3E931GK5CsB7GNiyWA6iQ25oBpSPXuNiRYm8e5pTAtjv8lIjeRTrH2LRkRlE5V5HTZiwSzWq1554fnzsxG6w9yR9XblOApOMmBK/zcnypwHBWj3iFPOQjxCQgzjTCNjgTDtTRygfQ4aiRSzvi7nIUYazPp7SHvaTjWgqUCB5w==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Edwin Torok <edvin.torok@xxxxxxxxxx>, Rob Hoes <Rob.Hoes@xxxxxxxxxx>
- Delivery-date: Thu, 20 Oct 2022 12:45:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY5HiMx9pkqyzOUUCkjGjpajJVHK4XOlXg
- Thread-topic: [PATCH for-4.17] tools/oxenstored: Fix Oxenstored Live Update
Hi Andrew,
> -----Original Message-----
> From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Subject: [PATCH for-4.17] tools/oxenstored: Fix Oxenstored Live Update
>
> tl;dr This hunk was part of the patch emailed to xen-devel, but was missing
> from what ultimately got committed.
>
> https://lore.kernel.org/xen-
> devel/4164cb728313c3b9fc38cf5e9ecb790ac93a9600.1610748224.git.edvin.t
> orok@xxxxxxxxxx/
> is the patch in question, but was part of a series that had threading issues.
> I have a vague recollection that I sourced the commits from a local branch,
> which clearly wasn't as up-to-date as I had thought.
>
> Either way, it's my fault/mistake, and this hunk should have been part of
> what
> got comitted.
>
> Fixes: 00c48f57ab36 ("tools/oxenstored: Start live update process")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Christian Lindig <christian.lindig@xxxxxxxxxx>
> CC: David Scott <dave@xxxxxxxxxx>
> CC: Edwin Torok <edvin.torok@xxxxxxxxxx>
> CC: Rob Hoes <Rob.Hoes@xxxxxxxxxx>
> CC: Henry Wang <Henry.Wang@xxxxxxx>
>
> Found while reviewing the XenServer patchqueue. This is low risk for 4.17
> and
> fixes a feature which we thought had been working since 4.15.
The commit message and above scissors line have described the situation
quite clear, so I don't think there is any reason to ignore this patch.
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
> ---
> tools/ocaml/xenstored/xenstored.ml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tools/ocaml/xenstored/xenstored.ml
> b/tools/ocaml/xenstored/xenstored.ml
> index d44ae673c42a..fc90fcdeb5d6 100644
> --- a/tools/ocaml/xenstored/xenstored.ml
> +++ b/tools/ocaml/xenstored/xenstored.ml
> @@ -352,6 +352,11 @@ let _ =
> rw_sock
> ) in
>
> + (* required for xenstore-control to detect availability of live-update
> *)
> + Store.mkdir store Perms.Connection.full_rights (Store.Path.of_string
> "/tool");
> + Store.write store Perms.Connection.full_rights
> + (Store.Path.of_string "/tool/xenstored")
> Sys.executable_name;
> +
> Sys.set_signal Sys.sighup (Sys.Signal_handle sighup_handler);
> Sys.set_signal Sys.sigterm (Sys.Signal_handle (fun _ ->
> info "Received SIGTERM";
> --
> 2.11.0
|
