[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN v1] GICv3: Emulate GICD_IGRPMODR as RAZ / WI
- To: Michal Orzel <michal.orzel@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Ayan Kumar Halder <ayankuma@xxxxxxx>
- Date: Thu, 20 Oct 2022 11:43:12 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aW1O3Jih8H5+JSUwTtyWGq4DG7pH4FcInZ0wMLtbKnc=; b=e4LQuRhMv9L3Tc9RadKqv2VNOH3i1if2cWpVxkXBEPGaXppoNYMqR9I9YG+7rSfUDJIVNqhLfu+q3Z8JVAMz2bcN5ZusVRum8RknYAZ8OwwjpcTOT/i6KDHrXL28n9qyyZ0QLhYGzrF68tvVYd1NbOE4dgmFHDBMqgmxjWGCde4KtU4+RIl/Ur0qPilea5owV7gLl5YT/VPRRF5GTujZ0xtI1WueRNdlRLVyautB89HMu+K/Vk25SsgIMSCnmzX2hzMeeA3eySSNn03TLKzkZRegJ6/o1JmYBcWF4b+KEJXziOtpDPxEzZyvRIE0xe1e49XDNrS36kmm/TGCPSoM6w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OAeiqK1ZQV1CC8tuLKeTN6J3PGM1qJJ0N8BaEqj/AEyhkuZRrLaYxj/wmpXD1pGJOhTZKvKuPM4ppQ1u2QtCnHbxJAfB6fJt0D0kS3y6Qjp1U6KowKK/MajtomYTWWzqPzUuSiN1TL72IIMHkMDcy4oAMe/5/73ggGrHdo1f79ak47CibQmUdVVpFw1AGdkr/RrsvsTtuzUrGMRO186emUenu/+iZoHBuduzwP2bqp/GkHokv/vcG2LafGWpfwMkCb/L1wmHDcxPeQTu0CI1CzbaWeo2/dtzqKDMqUcCZokS86m1mT/wWdjhfAuGsshZRAgWcBXqDSh8514YM4m7gw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: sstabellini@xxxxxxxxxx, stefanos@xxxxxxxxxx, julien@xxxxxxx, Volodymyr_Babchuk@xxxxxxxx, bertrand.marquis@xxxxxxx
- Delivery-date: Thu, 20 Oct 2022 10:43:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19/10/2022 16:49, Michal Orzel wrote:
Hi Ayan,
Hi Michal,
On 19/10/2022 16:36, Ayan Kumar Halder wrote:
Refer GIC v3 specification (Arm IHI 0069H ID020922), IGRPMODR (similar to
IGROUPR) is relevant only when the guests run in secure/non-secure mode.
As Xen does not implement security extensions for guests, so the registers
are emulated as read as zero/write ignore.
Signed-off-by: Ayan Kumar Halder <ayankuma@xxxxxxx>
---
Observed the issue while running Zephyr on R52.
Also, found that KVM has similar behaviour.
xen/arch/arm/include/asm/gic.h | 2 ++
xen/arch/arm/vgic-v3.c | 4 ++++
2 files changed, 6 insertions(+)
diff --git a/xen/arch/arm/include/asm/gic.h b/xen/arch/arm/include/asm/gic.h
index 76e3fa5dc4..998dd62651 100644
--- a/xen/arch/arm/include/asm/gic.h
+++ b/xen/arch/arm/include/asm/gic.h
@@ -48,6 +48,8 @@
#define GICD_ICFGR1 (0xC04)
#define GICD_ICFGR2 (0xC08)
#define GICD_ICFGRN (0xCFC)
+#define GICD_IGRPMODR (0xD00)
+#define GICD_IGRPMODRN (0xD7C)
These registers are GICv3 specific and as such should be defined
in arch/arm/include/asm/gic_v3_defs.h.
Thanks for pointing out. I have fixed this in v2.
- Ayan
~Michal
|
