[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] automation: test.yaml: Introduce templates to reduce the overhead
- To: Michal Orzel <michal.orzel@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jiamei Xie <Jiamei.Xie@xxxxxxx>
- Date: Thu, 20 Oct 2022 06:06:31 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XR8xoKIO59aqd5nvBPcfi+Vb+egPn9X+bVoWkdzuG8w=; b=lia6FEKWQ99GcTH5IStQKlN/cRYfBH5Y8Fgl9w3Bq8VLvo9e+xwLEwUiGpoDCCSAIWld/2VtNzn7phR5zUptRlrFgkxaHa4PWnljKzAy6tCIb2qkwR/fOnpuzpJSMauKw5ZyLq8PFb8315A3ASvtO+imRIQklJu1e1A/RMJqfarBwR6lRRLx5L/wxI+f3dLg77I5GCs1zMS9mduXmM7YKZOxz8JgTGVH1bXNsLGNY/7EqI11TlKrP3auljqHg3GEHDmLtlxWpvS4llE5Hxf0pZwT0jdQ5hRbS36CNI6IoF4Niq30ScdX9zxd0Yt6ExkgCsRUQUYkvBz42q6ivW8+YQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XR8xoKIO59aqd5nvBPcfi+Vb+egPn9X+bVoWkdzuG8w=; b=W/pF6L42BA9V9aArUa5tF8pE+QuX1GbKcuoAsXVD6oWasi2nYyJY/ivLDnzjclKt1jTP5ME0k9hJE034+NwiHvRYihHju/mxn95skGrDn9qVatOlN6yiL8l3b8aEfzee84RAqNRT/h29PxYIkmqrnY4AYc8q5Qy6W9jw/OfFCxbJqx0yNfj054xINWHek+YA2xhlwdChjdgBeDPCqap74jh5sItNJPANmoTiuWE3A9C0RbbX+PkNAvFAabOFdhaP4kXm+nYKHUOQg01eu+nWifT/kZJ6RK6DXRVwjyCZE1iZdIknYlWjA/OuxmxWNocENzT3lG1KdoNZS47c2Svxdg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ZV2V37J1P7U9AVbz7RfOImXEucQqM3/zuWL4DRg8wYa/u6MORBmHcuUDiovEqO7j30oz+2lFLuGA3+4FrkPjx+MH2eE4Eguw6OL66tIudE8OqYdP8RrCa2oNfsFcRzYdeN6Cp4OSlXj3j+HV44eT9OYtOALHhFc+QQVhufuAZJEze3+PbNzaxzBsBmQfTi+s/yxm+LFmrzMNXqQWsOoJvVzWqqsgb807h6zE0wPr9nwZm76whWaB31fUfRBArARc4C6hoVS7zNxhVreTu0nyMyBNBKKScrXwrf5eoXuooq3Tljt3VUzXenh6p8oeVaAVd8JYI9vqDc1GYjxA1pqJpw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NP0nsDDQYbl4QXQ7FnzbGY7Lv3xgpy6w3JbZBCql7W+Yq3j3cywGn16S2zraFHEeqe0O/fc368o4pGAQLTv8u66jHnxszvwk7cSmlYfzNphZYVehRr1aGWhGbTJs+mrIxapE8azVuVY/SrwQFonz5rXV0p6bwv3y1oTTCSAFfM73U8IWbbu63obi6uxRH2rlfSG+ViAsoX0lBGlWTfLa3rZGAZCCMjESeX7NUahgEXXPlkKC9WFOP/rxly0uIf0nuiEfd2fjR3fv3S1FsSqeJ3VmGHVNmiikwSyUBNY+Z/0GjqT7DjLmkVS61jynfRv9gnXZC5G0tfCC2bHaB8d14Q==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Thu, 20 Oct 2022 06:07:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY49ns8H4XagK8TEuA8KOvVnaQ864WxmAg
- Thread-topic: [PATCH] automation: test.yaml: Introduce templates to reduce the overhead
H Michal,
> -----Original Message-----
> From: Xen-devel <xen-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of
> Michal Orzel
> Sent: Thursday, October 20, 2022 12:43 AM
> To: xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Michal Orzel <michal.orzel@xxxxxxx>; Doug Goldstein
> <cardoe@xxxxxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Subject: [PATCH] automation: test.yaml: Introduce templates to reduce the
> overhead
>
> At the moment, we define lots of test jobs in test.yaml, that make use
> of the same configuration sections like variables, tags, artifacts.
> Introduce templates (hidden jobs whose names start with a dot) to
> reduce the overhead and simplify the file (more than 100 lines saved).
> This way, the actual jobs can only specify sections that are unique
> to them.
>
> Most of the test jobs specify the same set of prerequisite jobs under needs
> property with just one additional being unique to the job itself. Introduce
> YAML anchors for that purpose, because when using extends, the needs
> property
> is not being merged (the parent property overwrites the child one).
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
> This patch is based on the CI next branch where we already have several
> patches (already acked) to be merged into staging after the release:
> https://gitlab.com/xen-project/people/sstabellini/xen/-/tree/next
>
> Tested pipeline:
> https://gitlab.com/xen-project/people/morzel/xen-orzelmichal/-
> /pipelines/671114820
Looks good to me.
Reviewed-by: Jiamei.xie@xxxxxxx
|
